Stability instrumentation: metrics for collection on crash

components/browser_watcher/stability_report_user_stream_data_source.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/browser_watcher/stability_report_user_stream_data_source.h"
 
 #include <string>
 #include <utility>
 
 #include "base/files/file.h"
@@ skipping 55 matching lines @@
   DCHECK(!data_.empty());
   return data_.size();
 }
 
 bool BufferExtensionStreamDataSource::ReadStreamData(Delegate* delegate) {
   DCHECK(!data_.empty());
   return delegate->ExtensionStreamDataSourceRead(
       data_.size() ? data_.data() : nullptr, data_.size());
 }
 
+// DO NOT CHANGE VALUES. This is logged persistently in a histogram.
+enum class CollectionEvent {

[bcwhite, 2017/05/31 15:41:19]

Do you track failures?  You could have a kAttempts that is counted every time
and the kSuccess, etc. to indicate the things that happened within that attempt.

[manzagop (departed), 2017/05/31 19:57:23]

I've added a bunch of states. Done.

+  kSuccess = 0,

[bcwhite, 2017/05/31 15:41:19]

Omit the numbers and just say "do not insert or remove values because..."

[manzagop (departed), 2017/05/31 19:57:23]

Done.

+  kPmaSetDeletedFailed = 1,
+  kCollectionEventMax = 2
+};
+
+void LogCollectionEvent(CollectionEvent event) {
+  UMA_HISTOGRAM_ENUMERATION("ActivityTracker.CollectCrash.Event", event,
+                            CollectionEvent::kCollectionEventMax);
+}
+
+// TODO(manzagop): collection should factor in whether this is a true crash or
+// dump without crashing.
 std::unique_ptr<BufferExtensionStreamDataSource> CollectReport(
     const base::FilePath& path) {
   StabilityReport report;
   CollectionStatus status = Extract(path, &report);
   UMA_HISTOGRAM_ENUMERATION("ActivityTracker.CollectCrash.Status", status,
                             COLLECTION_STATUS_MAX);
   if (status != SUCCESS)
     return nullptr;
 
-  // Open (with delete) and then immediately close the file by going out of
-  // scope. This should cause the stability debugging file to be deleted prior
-  // to the next execution.
-  // TODO(manzagop): set the persistent allocator file's state to deleted in
-  //     case the file can't be deleted.
-  base::File file(path, base::File::FLAG_OPEN | base::File::FLAG_READ |
-                            base::File::FLAG_DELETE_ON_CLOSE);
-  UMA_HISTOGRAM_BOOLEAN("ActivityTracker.CollectCrash.OpenForDeleteSuccess",
-                        file.IsValid());
+  if (!MarkStabilityFileDeleted(path))
+    LogCollectionEvent(CollectionEvent::kPmaSetDeletedFailed);
+  LogCollectionEvent(CollectionEvent::kSuccess);
 
   std::unique_ptr<BufferExtensionStreamDataSource> source(
       new BufferExtensionStreamDataSource(kStabilityReportStreamType));
   return source->Init(report) ? std::move(source) : nullptr;
 }
 
 }  // namespace
 
 StabilityReportUserStreamDataSource::StabilityReportUserStreamDataSource(
     const base::FilePath& user_data_dir)
@@ skipping 12 matching lines @@
   if (!PathExists(stability_file)) {
     // Either this is not an instrumented process (currently only browser
     // processes can be instrumented), or the stability file cannot be found.
     return nullptr;
   }
 
   return CollectReport(stability_file);
 }
 
 }  // namespace browser_watcher