Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: tools/chrome_proxy/webdriver/common.py

Issue 2909943005: Refactor variations_combinations.py to use testing configs (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/chrome_proxy/webdriver/common.py
diff --git a/tools/chrome_proxy/webdriver/common.py b/tools/chrome_proxy/webdriver/common.py
index df9b022fa3123aecd6d3cc22ec114a3ffc649b76..04819c5b133d6bc1e8314248a289cdef78525678 100644
--- a/tools/chrome_proxy/webdriver/common.py
+++ b/tools/chrome_proxy/webdriver/common.py
@@ -742,6 +742,8 @@ class IntegrationTest(unittest.TestCase):
Args:
run_all_tests: If True, all tests in the directory will be run, Otherwise
only the tests in the file given on the command line will be run.
+ Returns:
+ the TestResult object from the test runner
"""
flags = ParseFlags()
logger = GetLogger()
@@ -767,4 +769,4 @@ class IntegrationTest(unittest.TestCase):
tests.addTest(test)
testRunner = unittest.runner.TextTestRunner(verbosity=2,
failfast=flags.failfast, buffer=(not flags.disable_buffer))
- testRunner.run(tests)
+ return testRunner.run(tests)
tbansal1 2017/05/30 23:31:23 why was this changed?
Robert Ogden 2017/05/30 23:44:35 So that the variations framework can tell if a tes

Powered by Google App Engine
This is Rietveld 408576698