Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2909943004: Write type parameters when writing members (issue 29714) (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 6 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Write type parameters when writing members (issue 29714) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/265ef252aeca0ef1b47b08ef905e870f615658e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -1 line) Patch
M pkg/analysis_server/test/analysis/get_hover_test.dart View 1 chunk +32 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 1 chunk +34 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 6 months ago (2017-05-30 19:07:39 UTC) #2
scheglov
LGTM
3 years, 6 months ago (2017-05-30 19:09:21 UTC) #3
Brian Wilkerson
3 years, 6 months ago (2017-05-30 19:19:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
265ef252aeca0ef1b47b08ef905e870f615658e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698