sandbox/win/src/process_mitigations_test.cc - Issue 2909943003: Removing useless Win7 checks + standardize its use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sandbox/win/src/process_mitigations_test.cc

Issue 2909943003: Removing useless Win7 checks + standardize its use (Closed)

Patch Set: Fix reversed conditionnal Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sandbox/win/src/process_mitigations_test.cc

diff --git a/sandbox/win/src/process_mitigations_test.cc b/sandbox/win/src/process_mitigations_test.cc

index 53b0442c1c54d0cc0a0fad6d7672448f57bea114..1e6b3420a0c2542db8cdc5a6fcd7e53166021dc9 100644

--- a/sandbox/win/src/process_mitigations_test.cc

+++ b/sandbox/win/src/process_mitigations_test.cc

@@ -948,7 +948,7 @@ SBOX_TESTS_COMMAND int CheckDep(int argc, wchar_t** argv) {

#if !defined(_WIN64) // DEP is always enabled on 64-bit.

TEST(ProcessMitigationsTest, CheckDep) {

- if (base::win::GetVersion() > base::win::VERSION_WIN7)

+ if (base::win::GetVersion() >= base::win::VERSION_WIN8)

return;

TestRunner runner;