cloud_print/virtual_driver/win/install/setup.cc - Issue 2909943003: Removing useless Win7 checks + standardize its use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/virtual_driver/win/install/setup.cc

Issue 2909943003: Removing useless Win7 checks + standardize its use (Closed)

Patch Set: Fix reversed conditionnal Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/virtual_driver/win/install/setup.cc

diff --git a/cloud_print/virtual_driver/win/install/setup.cc b/cloud_print/virtual_driver/win/install/setup.cc

index 70ae0ddd3503146242d82c90fd3bbf7525e50b80..fc353a1665a963012d3ca3c956abe7d1c57f7d2c 100644

--- a/cloud_print/virtual_driver/win/install/setup.cc

+++ b/cloud_print/virtual_driver/win/install/setup.cc

@@ -257,8 +257,7 @@ HRESULT UninstallPrinter(void) {

bool IsOSSupported() {

// We don't support Vista or older.

- base::win::Version version = base::win::GetVersion();

- return (version >= base::win::VERSION_WIN7);

+ return base::win::GetVersion() >= base::win::VERSION_WIN7;

}

HRESULT RegisterVirtualDriver(const base::FilePath& install_path) {