Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3150)

Unified Diff: chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc

Issue 2909943003: Removing useless Win7 checks + standardize its use (Closed)
Patch Set: Fix reversed conditionnal Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc
diff --git a/chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc b/chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc
index eef4638710b613649a18b4f1aa9cb38d5ea3daee..80e5953f533d111215e43b8ed0db2ab64f5d2c70 100644
--- a/chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc
+++ b/chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc
@@ -40,8 +40,8 @@ class SetAsDefaultBrowserUIBrowserTestWithFirstRun
IN_PROC_BROWSER_TEST_F(SetAsDefaultBrowserUIBrowserTestWithFirstRun, Test) {
// Windows 8 only test case.
- if (base::win::GetVersion() <= base::win::VERSION_WIN7 ||
- base::win::GetVersion() >= base::win::VERSION_WIN10) {
+ if (base::win::GetVersion() != base::win::VERSION_WIN8 &&
+ base::win::GetVersion() != base::win::VERSION_WIN8_1) {
Nico 2017/06/01 15:01:22 nit: To me, the prior `if (base::win::GetVersion()
Patrick Monette 2017/06/02 00:34:04 Acknowledged. I think I still prefer it this way s
return;
}
ASSERT_FALSE(IsBrowserVisible(browser()));

Powered by Google App Engine
This is Rietveld 408576698