chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc - Issue 2909943003: Removing useless Win7 checks + standardize its use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc

Issue 2909943003: Removing useless Win7 checks + standardize its use (Closed)

Patch Set: Fix reversed conditionnal Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/pdf/adobe_reader_info_win.cc ('K') | « chrome/browser/ui/views/frame/taskbar_decorator_win.cc ('k') | chrome/browser/unload_browsertest.cc » ('j') | chrome/installer/util/shell_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc

diff --git a/chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc b/chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc

index eef4638710b613649a18b4f1aa9cb38d5ea3daee..80e5953f533d111215e43b8ed0db2ab64f5d2c70 100644

--- a/chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc

+++ b/chrome/browser/ui/webui/set_as_default_browser_ui_browsertest_win.cc

@@ -40,8 +40,8 @@ class SetAsDefaultBrowserUIBrowserTestWithFirstRun

IN_PROC_BROWSER_TEST_F(SetAsDefaultBrowserUIBrowserTestWithFirstRun, Test) {

// Windows 8 only test case.

- if (base::win::GetVersion() <= base::win::VERSION_WIN7 ||

- base::win::GetVersion() >= base::win::VERSION_WIN10) {

+ if (base::win::GetVersion() != base::win::VERSION_WIN8 &&

+ base::win::GetVersion() != base::win::VERSION_WIN8_1) {

Nico 2017/06/01 15:01:22 nit: To me, the prior `if (base::win::GetVersion()

Patrick Monette 2017/06/02 00:34:04 Acknowledged. I think I still prefer it this way s

return;

}

ASSERT_FALSE(IsBrowserVisible(browser()));