Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6269)

Unified Diff: chrome/browser/ui/pdf/adobe_reader_info_win.cc

Issue 2909943003: Removing useless Win7 checks + standardize its use (Closed)
Patch Set: Fix reversed conditionnal Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/pdf/adobe_reader_info_win.cc
diff --git a/chrome/browser/ui/pdf/adobe_reader_info_win.cc b/chrome/browser/ui/pdf/adobe_reader_info_win.cc
index 16893f6ee6d8f3f49015c3f9b61766c784ce1158..30cfdc8f92be805777212376b908853d5f447e34 100644
--- a/chrome/browser/ui/pdf/adobe_reader_info_win.cc
+++ b/chrome/browser/ui/pdf/adobe_reader_info_win.cc
@@ -18,7 +18,6 @@
#include "base/strings/utf_string_conversions.h"
#include "base/version.h"
#include "base/win/registry.h"
-#include "base/win/windows_version.h"
#include "chrome/browser/browser_process.h"
namespace {
@@ -41,9 +40,7 @@ base::FilePath GetInstalledPath(const base::char16* app) {
base::FilePath filepath;
base::win::RegKey hkcu_key(HKEY_CURRENT_USER, reg_path.c_str(), KEY_READ);
base::string16 path;
- // As of Win7 AppPaths can also be registered in HKCU: http://goo.gl/UgFOf.
Nico 2017/06/01 15:01:22 Keep comment with s/As of Win7//
Patrick Monette 2017/06/02 00:34:04 Done.
- if (base::win::GetVersion() >= base::win::VERSION_WIN7 &&
- hkcu_key.ReadValue(kRegistryPath, &path) == ERROR_SUCCESS) {
+ if (hkcu_key.ReadValue(kRegistryPath, &path) == ERROR_SUCCESS) {
filepath = base::FilePath(path);
} else {
base::win::RegKey hklm_key(HKEY_LOCAL_MACHINE, reg_path.c_str(), KEY_READ);

Powered by Google App Engine
This is Rietveld 408576698