chrome/browser/media/webrtc/webrtc_browsertest_base.cc - Issue 2909943003: Removing useless Win7 checks + standardize its use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc/webrtc_browsertest_base.cc

Issue 2909943003: Removing useless Win7 checks + standardize its use (Closed)

Patch Set: Fix unreachable code Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/webrtc/webrtc_browsertest_base.cc

diff --git a/chrome/browser/media/webrtc/webrtc_browsertest_base.cc b/chrome/browser/media/webrtc/webrtc_browsertest_base.cc

index 562ca644f58308216cd5b89fd62b6f097fb5b171..8b3e2d5072e3ecc0dc26981c4a9bbc376b4ba65d 100644

--- a/chrome/browser/media/webrtc/webrtc_browsertest_base.cc

+++ b/chrome/browser/media/webrtc/webrtc_browsertest_base.cc

@@ -463,7 +463,7 @@ std::string WebRtcTestBase::GetStreamSize(

bool WebRtcTestBase::OnWin8() const {

#if defined(OS_WIN)

- return base::win::GetVersion() > base::win::VERSION_WIN7;

+ return base::win::GetVersion() <= base::win::VERSION_WIN8;

Reilly Grant (use Gerrit) 2017/06/01 01:22:54 This is inverting the condition.

Patrick Monette 2017/06/01 01:59:17 Good catch! I tried to be careful. Fixed.

#else

return false;

#endif