Removing useless Win7 checks + standardize its use

base/test/test_shortcut_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/test/test_shortcut_win.h"
 
 #include <windows.h>
 #include <objbase.h>
 #include <shlobj.h>
 #include <propkey.h>
 
 #include "base/files/file_path.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/scoped_comptr.h"
 #include "base/win/scoped_propvariant.h"
-#include "base/win/windows_version.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 namespace win {
 
 void ValidatePathsAreEqual(const base::FilePath& expected_path,
                            const base::FilePath& actual_path) {
   wchar_t long_expected_path_chars[MAX_PATH] = {0};
   wchar_t long_actual_path_chars[MAX_PATH] = {0};
 
@@ skipping 78 matching lines @@
     EXPECT_EQ(properties.description, read_description);
   }
 
   if (properties.options & ShortcutProperties::PROPERTIES_ICON) {
     EXPECT_TRUE(SUCCEEDED(
         i_shell_link->GetIconLocation(read_icon, MAX_PATH, &read_icon_index)));
     ValidatePathsAreEqual(properties.icon, base::FilePath(read_icon));
     EXPECT_EQ(properties.icon_index, read_icon_index);
   }
 
-  if (GetVersion() >= VERSION_WIN7) {
-    ScopedComPtr<IPropertyStore> property_store;
-    EXPECT_TRUE(
-        SUCCEEDED(hr = i_shell_link.CopyTo(property_store.GetAddressOf())));
-    if (FAILED(hr))
-      return;
+  ScopedComPtr<IPropertyStore> property_store;
+  EXPECT_TRUE(
+      SUCCEEDED(hr = i_shell_link.CopyTo(property_store.GetAddressOf())));
+  if (FAILED(hr))
+    return;
 
-    if (properties.options & ShortcutProperties::PROPERTIES_APP_ID) {
-      ScopedPropVariant pv_app_id;
-      EXPECT_EQ(S_OK, property_store->GetValue(PKEY_AppUserModel_ID,
-                                               pv_app_id.Receive()));
-      switch (pv_app_id.get().vt) {
-        case VT_EMPTY:
-          EXPECT_TRUE(properties.app_id.empty());
-          break;
-        case VT_LPWSTR:
-          EXPECT_EQ(properties.app_id, pv_app_id.get().pwszVal);
-          break;
-        default:
-          ADD_FAILURE() << "Unexpected variant type: " << pv_app_id.get().vt;
-      }
+  if (properties.options & ShortcutProperties::PROPERTIES_APP_ID) {
+    ScopedPropVariant pv_app_id;
+    EXPECT_EQ(S_OK, property_store->GetValue(PKEY_AppUserModel_ID,
+                                             pv_app_id.Receive()));
+    switch (pv_app_id.get().vt) {
+      case VT_EMPTY:
+        EXPECT_TRUE(properties.app_id.empty());
+        break;
+      case VT_LPWSTR:
+        EXPECT_EQ(properties.app_id, pv_app_id.get().pwszVal);
+        break;
+      default:
+        ADD_FAILURE() << "Unexpected variant type: " << pv_app_id.get().vt;
     }
+  }
 
-    if (properties.options & ShortcutProperties::PROPERTIES_DUAL_MODE) {
-      ScopedPropVariant pv_dual_mode;
-      EXPECT_EQ(S_OK, property_store->GetValue(PKEY_AppUserModel_IsDualMode,
-                                               pv_dual_mode.Receive()));
-      switch (pv_dual_mode.get().vt) {
-        case VT_EMPTY:
-          EXPECT_FALSE(properties.dual_mode);
-          break;
-        case VT_BOOL:
-          EXPECT_EQ(properties.dual_mode,
-                    static_cast<bool>(pv_dual_mode.get().boolVal));
-          break;
-        default:
-          ADD_FAILURE() << "Unexpected variant type: " << pv_dual_mode.get().vt;
-      }
+  if (properties.options & ShortcutProperties::PROPERTIES_DUAL_MODE) {
+    ScopedPropVariant pv_dual_mode;
+    EXPECT_EQ(S_OK, property_store->GetValue(PKEY_AppUserModel_IsDualMode,
+                                             pv_dual_mode.Receive()));
+    switch (pv_dual_mode.get().vt) {
+      case VT_EMPTY:
+        EXPECT_FALSE(properties.dual_mode);
+        break;
+      case VT_BOOL:
+        EXPECT_EQ(properties.dual_mode,
+                  static_cast<bool>(pv_dual_mode.get().boolVal));
+        break;
+      default:
+        ADD_FAILURE() << "Unexpected variant type: " << pv_dual_mode.get().vt;
     }
   }
 }
 
 }  // namespace win
 }  // namespace base