Issue 290993009: Reland r21346 "Inobject slack tracking is done on a per-closure basis instead of per-shared info ba…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 290993009: Reland r21346 "Inobject slack tracking is done on a per-closure basis instead of per-shared info ba… (Closed)

Created:
6 years, 7 months ago by Igor Sheludko

Modified:
6 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Reland r21346 "Inobject slack tracking is done on a per-closure basis instead of per-shared info basis." This fixes inobject slack tracking for prototype inheritance pattern that uses closures. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21442

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+279 lines, -437 lines)			Patch
M	src/arm/builtins-arm.cc	View		8 chunks	+32 lines, -32 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View		1 chunk	+11 lines, -3 lines	0 comments	Download
M	src/arm64/builtins-arm64.cc	View		9 chunks	+40 lines, -44 lines	0 comments	Download
M	src/arm64/macro-assembler-arm64.h	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	src/builtins.h	View		2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/compiler.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/factory.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/heap.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap-snapshot-generator.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/hydrogen.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/builtins-ia32.cc	View	1	8 chunks	+37 lines, -28 lines	0 comments	Download
M	src/mark-compact.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/mark-compact.cc	View		3 chunks	+0 lines, -26 lines	0 comments	Download
M	src/objects.h	View		10 chunks	+60 lines, -116 lines	0 comments	Download
M	src/objects.cc	View		5 chunks	+17 lines, -73 lines	0 comments	Download
M	src/objects-inl.h	View		6 chunks	+26 lines, -37 lines	0 comments	Download
M	src/runtime.cc	View		3 chunks	+7 lines, -22 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View	1	8 chunks	+36 lines, -29 lines	0 comments	Download
M	test/cctest/test-mementos.cc	View		2 chunks	+3 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Igor Sheludko

PTAL. The problem was that with my changes the esi/rsi were clobbered at the point ...

6 years, 7 months ago (2014-05-22 15:52:25 UTC) #1

Igor Sheludko

6 years, 7 months ago (2014-05-22 16:22:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21442 (presubmit successful).