Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issue 290993006: Pepper: Remove Quota management from TempFile. (Closed)

Created:
6 years, 7 months ago by teravest
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Remove Quota management from TempFile. TempFile quota management only serves to limit the write limits of the llc and ld processes when translating PNaCl pexe files. There are many other ways to fill the disk, so this doesn't serve much purpose, and the code will be simpler to understand without it. I hope to remove MakeFileDescQuota() from native_client after making that change, and removing the implementation, including the necessary methods in nacl::ReverseInterface. BUG=239656 R=jvoung@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272210

Patch Set 1 : #

Total comments: 2

Patch Set 2 : fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -86 lines) Patch
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/service_runtime.h View 1 4 chunks +2 lines, -13 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/service_runtime.cc View 2 chunks +0 lines, -33 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/temporary_file.h View 1 3 chunks +0 lines, -14 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/temporary_file.cc View 4 chunks +4 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
teravest
6 years, 7 months ago (2014-05-22 14:32:50 UTC) #1
jvoung (off chromium)
Actually, looks like eventually chrome folks do want to plug filldisk bugs (sounds like it ...
6 years, 7 months ago (2014-05-22 16:22:48 UTC) #2
teravest
Thanks! On Thu, May 22, 2014 at 10:22 AM, <jvoung@chromium.org> wrote: > Actually, looks like ...
6 years, 7 months ago (2014-05-22 16:26:51 UTC) #3
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 7 months ago (2014-05-22 16:32:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/290993006/70001
6 years, 7 months ago (2014-05-22 16:33:23 UTC) #5
teravest
6 years, 7 months ago (2014-05-22 17:14:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r272210 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698