ppapi/cpp/media_stream_audio_track.h - Issue 290993005: Support configuring number of audio buffers in MediaStream Pepper API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/cpp/media_stream_audio_track.h

Issue 290993005: Support configuring number of audio buffers in MediaStream Pepper API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix uninitialized variable Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/cpp/media_stream_audio_track.h

diff --git a/ppapi/cpp/media_stream_audio_track.h b/ppapi/cpp/media_stream_audio_track.h

index 19e76b84afc55c82ecbfe9d5c0e928fab2b4687c..680e52b832e804574e8f14349fe672bce062a11b 100644

--- a/ppapi/cpp/media_stream_audio_track.h

+++ b/ppapi/cpp/media_stream_audio_track.h

@@ -56,7 +56,8 @@ class MediaStreamAudioTrack : public Resource {

/// all input buffers. If all buffers are filled, then samples will be

/// dropped. The application can detect this by examining the timestamp on

/// returned buffers. If <code>Configure()</code> is not called, default

- /// settings will be used.

+ /// settings will be used. Calls to Configure while the plugin holds

+ /// buffers will fail.

/// Example usage from plugin code:

/// @code

/// int32_t attribs[] = {

« no previous file with comments | « ppapi/c/ppb_media_stream_audio_track.h ('k') | ppapi/ppapi_shared.gypi » ('j') | no next file with comments »