Support configuring number of audio buffers in MediaStream Pepper API.

content/renderer/pepper/pepper_media_stream_track_host_base.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_media_stream_track_host_base.h"
 
 #include "base/logging.h"
+#include "base/numerics/safe_math.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/renderer_ppapi_host.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/host/dispatch_host_message.h"
 #include "ppapi/host/host_message_context.h"
 #include "ppapi/host/ppapi_host.h"
 #include "ppapi/proxy/ppapi_messages.h"
 #include "ppapi/shared_impl/media_stream_buffer.h"
 
 using ppapi::host::HostMessageContext;
@@ skipping 11 matching lines @@
 
 PepperMediaStreamTrackHostBase::~PepperMediaStreamTrackHostBase() {}
 
 bool PepperMediaStreamTrackHostBase::InitBuffers(int32_t number_of_buffers,
                                                  int32_t buffer_size,
                                                  TrackType track_type) {
   DCHECK_GT(number_of_buffers, 0);
   DCHECK_GT(buffer_size,
             static_cast<int32_t>(sizeof(ppapi::MediaStreamBuffer::Header)));
   // Make each buffer 4 byte aligned.
-  buffer_size = (buffer_size + 3) & ~0x3;
+  base::CheckedNumeric<int32_t> buffer_size_aligned = buffer_size;
+  buffer_size_aligned += (4 - buffer_size % 4);
 
   // TODO(penghuang): |HostAllocateSharedMemoryBuffer| uses sync IPC. We should
   // avoid it.
-  int32_t size = number_of_buffers * buffer_size;
+  base::CheckedNumeric<int32_t> size = number_of_buffers * buffer_size_aligned;
+  if (!buffer_size_aligned.IsValid() || !size.IsValid())

[dcheng, 2014/06/02 21:57:23]

Nit: you only need to check size.IsValid() -- the validity of
buffer_size_aligned is propagated in CheckedNumeric math.

+    return false;
+
   content::RenderThread* render_thread = content::RenderThread::Get();
   scoped_ptr<base::SharedMemory> shm(
-      render_thread->HostAllocateSharedMemoryBuffer(size).Pass());
+      render_thread->HostAllocateSharedMemoryBuffer(size.ValueOrDie()).Pass());
   if (!shm)
     return false;
 
   base::SharedMemoryHandle shm_handle = shm->handle();
-  if (!buffer_manager_.SetBuffers(
-          number_of_buffers, buffer_size, shm.Pass(), true)) {
+  if (!buffer_manager_.SetBuffers(number_of_buffers,
+                                  buffer_size_aligned.ValueOrDie(),
+                                  shm.Pass(),
+                                  true)) {
     return false;
   }
 
   base::PlatformFile platform_file =
 #if defined(OS_WIN)
       shm_handle;
 #elif defined(OS_POSIX)
       shm_handle.fd;
 #else
 #error Not implemented.
 #endif
   SerializedHandle handle(host_->ShareHandleWithRemote(platform_file, false),
-                          size);
+                          size.ValueOrDie());
   bool readonly = (track_type == kRead);
   host()->SendUnsolicitedReplyWithHandles(
       pp_resource(),
-      PpapiPluginMsg_MediaStreamTrack_InitBuffers(number_of_buffers,
-                                                  buffer_size,
-                                                  readonly),
+      PpapiPluginMsg_MediaStreamTrack_InitBuffers(
+          number_of_buffers,
+          buffer_size_aligned.ValueOrDie(),
+          readonly),
       std::vector<SerializedHandle>(1, handle));
   return true;
 }
 
 void PepperMediaStreamTrackHostBase::SendEnqueueBufferMessageToPlugin(
     int32_t index) {
   DCHECK_GE(index, 0);
   DCHECK_LT(index, buffer_manager_.number_of_buffers());
   host()->SendUnsolicitedReply(
       pp_resource(), PpapiPluginMsg_MediaStreamTrack_EnqueueBuffer(index));
@@ skipping 25 matching lines @@
   return PP_OK;
 }
 
 int32_t PepperMediaStreamTrackHostBase::OnHostMsgClose(
     HostMessageContext* context) {
   OnClose();
   return PP_OK;
 }
 
 }  // namespace content