Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: runtime/vm/il_printer.cc

Issue 290993003: VM: Remove unnecessary field use_kind from IL instructions. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/il_printer.cc
===================================================================
--- runtime/vm/il_printer.cc (revision 36349)
+++ runtime/vm/il_printer.cc (working copy)
@@ -170,17 +170,15 @@
static void PrintUse(BufferFormatter* f, const Definition& definition) {
- if (definition.is_used()) {
- if (definition.HasSSATemp()) {
- if (definition.HasPairRepresentation()) {
- f->Print("v%" Pd ", v%" Pd "", definition.ssa_temp_index(),
- definition.ssa_temp_index() + 1);
- } else {
- f->Print("v%" Pd "", definition.ssa_temp_index());
- }
- } else if (definition.temp_index() != -1) {
- f->Print("t%" Pd "", definition.temp_index());
+ if (definition.HasSSATemp()) {
+ if (definition.HasPairRepresentation()) {
+ f->Print("v%" Pd ", v%" Pd "", definition.ssa_temp_index(),
+ definition.ssa_temp_index() + 1);
+ } else {
+ f->Print("v%" Pd "", definition.ssa_temp_index());
}
+ } else if (definition.HasTemp()) {
+ f->Print("t%" Pd "", definition.temp_index());
}
}
@@ -214,9 +212,7 @@
void Definition::PrintTo(BufferFormatter* f) const {
PrintUse(f, *this);
- if (is_used()) {
- if (HasSSATemp() || (temp_index() != -1)) f->Print(" <- ");
- }
+ if (HasSSATemp() || HasTemp()) f->Print(" <- ");
if (GetDeoptId() != Isolate::kNoDeoptId) {
f->Print("%s:%" Pd "(", DebugName(), GetDeoptId());
} else {

Powered by Google App Engine
This is Rietveld 408576698