Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: test/cctest/test-debug.cc

Issue 2909893002: [debug] Untangle DebugInfo from break point support (Closed)
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects/shared-function-info-inl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index 9750482feacf9ea3422927d5427a5b957b2e1959..5ca45079744867f8b2c34537b5b97e0970b797e2 100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -158,11 +158,11 @@ static void SetDebugEventListener(
}
// Is there any debug info for the function?
-static bool HasDebugInfo(v8::Local<v8::Function> fun) {
+static bool HasBreakInfo(v8::Local<v8::Function> fun) {
Handle<v8::internal::JSFunction> f =
Handle<v8::internal::JSFunction>::cast(v8::Utils::OpenHandle(*fun));
Handle<v8::internal::SharedFunctionInfo> shared(f->shared());
- return shared->HasDebugInfo();
+ return shared->HasBreakInfo();
}
// Set a break point in a function with a position relative to function start,
@@ -906,30 +906,30 @@ TEST(DebugInfo) {
CompileFunction(&env, "function bar(){}", "bar");
// Initially no functions are debugged.
CHECK_EQ(0, v8::internal::GetDebuggedFunctions()->length());
- CHECK(!HasDebugInfo(foo));
- CHECK(!HasDebugInfo(bar));
+ CHECK(!HasBreakInfo(foo));
+ CHECK(!HasBreakInfo(bar));
EnableDebugger(env->GetIsolate());
// One function (foo) is debugged.
int bp1 = SetBreakPoint(foo, 0);
CHECK_EQ(1, v8::internal::GetDebuggedFunctions()->length());
- CHECK(HasDebugInfo(foo));
- CHECK(!HasDebugInfo(bar));
+ CHECK(HasBreakInfo(foo));
+ CHECK(!HasBreakInfo(bar));
// Two functions are debugged.
int bp2 = SetBreakPoint(bar, 0);
CHECK_EQ(2, v8::internal::GetDebuggedFunctions()->length());
- CHECK(HasDebugInfo(foo));
- CHECK(HasDebugInfo(bar));
+ CHECK(HasBreakInfo(foo));
+ CHECK(HasBreakInfo(bar));
// One function (bar) is debugged.
ClearBreakPoint(bp1);
CHECK_EQ(1, v8::internal::GetDebuggedFunctions()->length());
- CHECK(!HasDebugInfo(foo));
- CHECK(HasDebugInfo(bar));
+ CHECK(!HasBreakInfo(foo));
+ CHECK(HasBreakInfo(bar));
// No functions are debugged.
ClearBreakPoint(bp2);
DisableDebugger(env->GetIsolate());
CHECK_EQ(0, v8::internal::GetDebuggedFunctions()->length());
- CHECK(!HasDebugInfo(foo));
- CHECK(!HasDebugInfo(bar));
+ CHECK(!HasBreakInfo(foo));
+ CHECK(!HasBreakInfo(bar));
}
@@ -6401,7 +6401,7 @@ TEST(BreakLocationIterator) {
Handle<i::SharedFunctionInfo> shared(function->shared());
EnableDebugger(isolate);
- CHECK(i_isolate->debug()->EnsureDebugInfo(shared));
+ CHECK(i_isolate->debug()->EnsureBreakInfo(shared));
Handle<i::DebugInfo> debug_info(shared->GetDebugInfo());
Handle<i::AbstractCode> abstract_code(shared->abstract_code());
« no previous file with comments | « src/objects/shared-function-info-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698