Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: src/objects/debug-objects.h

Issue 2909893002: [debug] Untangle DebugInfo from break point support (Closed)
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-printer.cc ('k') | src/objects/debug-objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects/debug-objects.h
diff --git a/src/objects/debug-objects.h b/src/objects/debug-objects.h
index dfb529c87d56be94f7bb3013f6b5d4068e4ba3c7..66edfac1c3ec5b637c488beb4cd0bf0499882547 100644
--- a/src/objects/debug-objects.h
+++ b/src/objects/debug-objects.h
@@ -17,13 +17,37 @@ namespace internal {
// debugged.
class DebugInfo : public Struct {
public:
+ enum Flag {
+ kNone = 0,
+ kHasBreakInfo = 1 << 0,
+ kHasCoverageInfo = 1 << 1,
+ };
+ typedef base::Flags<Flag> Flags;
+
+ // A bitfield that lists uses of the current instance.
+ DECL_INT_ACCESSORS(flags)
+
// The shared function info for the source being debugged.
DECL_ACCESSORS(shared, SharedFunctionInfo)
// Bit field containing various information collected for debugging.
DECL_INT_ACCESSORS(debugger_hints)
+ // DebugInfo can be detached from the SharedFunctionInfo iff it is empty.
+ bool IsEmpty() const;
+
+ // --- Break points ---
+ // --------------------
+
+ bool HasBreakInfo() const;
+
+ // Clears all fields related to break points. Returns true iff the
+ // DebugInfo is now empty.
+ bool ClearBreakInfo();
+
+ // The instrumented bytecode array for functions with break points.
DECL_ACCESSORS(debug_bytecode_array, Object)
+
// Fixed array holding status information for each active break point.
DECL_ACCESSORS(break_points, FixedArray)
@@ -56,14 +80,15 @@ class DebugInfo : public Struct {
DECLARE_PRINTER(DebugInfo)
DECLARE_VERIFIER(DebugInfo)
- static const int kSharedFunctionInfoIndex = Struct::kHeaderSize;
- static const int kDebuggerHintsIndex =
- kSharedFunctionInfoIndex + kPointerSize;
- static const int kDebugBytecodeArrayIndex =
- kDebuggerHintsIndex + kPointerSize;
- static const int kBreakPointsStateIndex =
- kDebugBytecodeArrayIndex + kPointerSize;
- static const int kSize = kBreakPointsStateIndex + kPointerSize;
+ static const int kSharedFunctionInfoOffset = Struct::kHeaderSize;
+ static const int kDebuggerHintsOffset =
+ kSharedFunctionInfoOffset + kPointerSize;
+ static const int kDebugBytecodeArrayOffset =
+ kDebuggerHintsOffset + kPointerSize;
+ static const int kBreakPointsStateOffset =
+ kDebugBytecodeArrayOffset + kPointerSize;
+ static const int kFlagsOffset = kBreakPointsStateOffset + kPointerSize;
+ static const int kSize = kFlagsOffset + kPointerSize;
static const int kEstimatedNofBreakPointsInFunction = 4;
@@ -100,8 +125,8 @@ class BreakPointInfo : public Tuple2 {
DECLARE_CAST(BreakPointInfo)
- static const int kSourcePositionIndex = kValue1Offset;
- static const int kBreakPointObjectsIndex = kValue2Offset;
+ static const int kSourcePositionOffset = kValue1Offset;
+ static const int kBreakPointObjectsOffset = kValue2Offset;
private:
DISALLOW_IMPLICIT_CONSTRUCTORS(BreakPointInfo);
« no previous file with comments | « src/objects-printer.cc ('k') | src/objects/debug-objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698