Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: src/debug/liveedit.cc

Issue 2909893002: [debug] Untangle DebugInfo from break point support (Closed)
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug-scopes.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/liveedit.cc
diff --git a/src/debug/liveedit.cc b/src/debug/liveedit.cc
index 6dab0028c85140387f6e28103c15195d78daad99..41c4a8f7e525220e54e140eef27c599ba79abf9f 100644
--- a/src/debug/liveedit.cc
+++ b/src/debug/liveedit.cc
@@ -910,9 +910,9 @@ void LiveEdit::ReplaceFunctionCode(
}
}
- if (shared_info->HasDebugInfo()) {
+ if (shared_info->HasBreakInfo()) {
// Existing break points will be re-applied. Reset the debug info here.
- isolate->debug()->RemoveDebugInfoAndClearFromShared(
+ isolate->debug()->RemoveBreakInfoAndMaybeFree(
handle(shared_info->GetDebugInfo()));
}
shared_info->set_scope_info(new_shared_info->scope_info());
@@ -1073,9 +1073,9 @@ void LiveEdit::PatchFunctionPositions(Handle<JSArray> shared_info_array,
Handle<AbstractCode>(AbstractCode::cast(info->code())),
position_change_array);
}
- if (info->HasDebugInfo()) {
+ if (info->HasBreakInfo()) {
// Existing break points will be re-applied. Reset the debug info here.
- info->GetIsolate()->debug()->RemoveDebugInfoAndClearFromShared(
+ info->GetIsolate()->debug()->RemoveBreakInfoAndMaybeFree(
handle(info->GetDebugInfo()));
}
}
« no previous file with comments | « src/debug/debug-scopes.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698