Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: src/debug/debug.h

Issue 2909893002: [debug] Untangle DebugInfo from break point support (Closed)
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/debug/debug.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.h
diff --git a/src/debug/debug.h b/src/debug/debug.h
index ae2a26d41a305ab0b231e9c667d16dd5cdd1e016..906a34f128fd820aa8f1960b4e3db2cdc5421521 100644
--- a/src/debug/debug.h
+++ b/src/debug/debug.h
@@ -332,9 +332,9 @@ class Debug {
void SetDebugDelegate(debug::DebugDelegate* delegate, bool pass_ownership);
// Returns whether the operation succeeded.
- bool EnsureDebugInfo(Handle<SharedFunctionInfo> shared);
- void CreateDebugInfo(Handle<SharedFunctionInfo> shared);
- static Handle<DebugInfo> GetDebugInfo(Handle<SharedFunctionInfo> shared);
+ bool EnsureBreakInfo(Handle<SharedFunctionInfo> shared);
+ void CreateBreakInfo(Handle<SharedFunctionInfo> shared);
+ Handle<DebugInfo> GetOrCreateDebugInfo(Handle<SharedFunctionInfo> shared);
template <typename C>
bool CompileToRevealInnerFunctions(C* compilable);
@@ -496,7 +496,6 @@ class Debug {
bool IsFrameBlackboxed(JavaScriptFrame* frame);
void ActivateStepOut(StackFrame* frame);
- void RemoveDebugInfoAndClearFromShared(Handle<DebugInfo> debug_info);
MaybeHandle<FixedArray> CheckBreakPoints(Handle<DebugInfo> debug_info,
BreakLocation* location,
bool* has_break_points = nullptr);
@@ -514,6 +513,11 @@ class Debug {
void PrintBreakLocation();
+ void RemoveBreakInfoAndMaybeFree(Handle<DebugInfo> debug_info);
+ void FindDebugInfo(Handle<DebugInfo> debug_info, DebugInfoListNode** prev,
+ DebugInfoListNode** curr);
+ void FreeDebugInfoListNode(DebugInfoListNode* prev, DebugInfoListNode* node);
+
// Global handles.
Handle<Context> debug_context_;
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/debug/debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698