Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: src/compiler.cc

Issue 2909893002: [debug] Untangle DebugInfo from break point support (Closed)
Patch Set: Address comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/x87/builtins-x87.cc ('k') | src/compiler/js-inlining.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index c2d63fb0418d859372705cf41b9d5e5a0da9885b..a6cbe661e23374f80ad0f7e422a5670a58c9707c 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -906,7 +906,7 @@ MaybeHandle<Code> GetOptimizedCode(Handle<JSFunction> function,
info->SetOptimizingForOsr(osr_ast_id, osr_frame);
// Do not use Crankshaft/TurboFan if we need to be able to set break points.
- if (info->shared_info()->HasDebugInfo()) {
+ if (info->shared_info()->HasBreakInfo()) {
info->AbortOptimization(kFunctionBeingDebugged);
return MaybeHandle<Code>();
}
@@ -1006,7 +1006,7 @@ CompilationJob::Status FinalizeOptimizedCompilationJob(CompilationJob* job) {
// Shared function no longer needs to be tiered up.
shared->set_marked_for_tier_up(false);
- DCHECK(!shared->HasDebugInfo());
+ DCHECK(!shared->HasBreakInfo());
// 1) Optimization on the concurrent thread may have failed.
// 2) The function may have already been optimized by OSR. Simply continue.
« no previous file with comments | « src/builtins/x87/builtins-x87.cc ('k') | src/compiler/js-inlining.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698