Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Side by Side Diff: src/objects/shared-function-info-inl.h

Issue 2909893002: [debug] Untangle DebugInfo from break point support (Closed)
Patch Set: Address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects/shared-function-info.h ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 the V8 project authors. All rights reserved. 1 // Copyright 2017 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_OBJECTS_SHARED_FUNCTION_INFO_INL_H_ 5 #ifndef V8_OBJECTS_SHARED_FUNCTION_INFO_INL_H_
6 #define V8_OBJECTS_SHARED_FUNCTION_INFO_INL_H_ 6 #define V8_OBJECTS_SHARED_FUNCTION_INFO_INL_H_
7 7
8 #include "src/heap/heap-inl.h" 8 #include "src/heap/heap-inl.h"
9 #include "src/objects/shared-function-info.h" 9 #include "src/objects/shared-function-info.h"
10 10
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 return length() != kInvalidLength; 270 return length() != kInvalidLength;
271 } 271 }
272 272
273 bool SharedFunctionInfo::has_simple_parameters() { 273 bool SharedFunctionInfo::has_simple_parameters() {
274 return scope_info()->HasSimpleParameters(); 274 return scope_info()->HasSimpleParameters();
275 } 275 }
276 276
277 bool SharedFunctionInfo::HasDebugInfo() const { 277 bool SharedFunctionInfo::HasDebugInfo() const {
278 bool has_debug_info = !debug_info()->IsSmi(); 278 bool has_debug_info = !debug_info()->IsSmi();
279 DCHECK_EQ(debug_info()->IsStruct(), has_debug_info); 279 DCHECK_EQ(debug_info()->IsStruct(), has_debug_info);
280 DCHECK(!has_debug_info || HasDebugCode());
281 return has_debug_info; 280 return has_debug_info;
282 } 281 }
283 282
284 bool SharedFunctionInfo::HasDebugCode() const { 283 bool SharedFunctionInfo::HasDebugCode() const {
285 if (HasBaselineCode()) return code()->has_debug_break_slots(); 284 if (HasBaselineCode()) return code()->has_debug_break_slots();
286 return HasBytecodeArray(); 285 return HasBytecodeArray();
287 } 286 }
288 287
289 bool SharedFunctionInfo::IsApiFunction() { 288 bool SharedFunctionInfo::IsApiFunction() {
290 return function_data()->IsFunctionTemplateInfo(); 289 return function_data()->IsFunctionTemplateInfo();
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
446 bool SharedFunctionInfo::IsSubjectToDebugging() { 445 bool SharedFunctionInfo::IsSubjectToDebugging() {
447 return IsUserJavaScript() && !HasAsmWasmData(); 446 return IsUserJavaScript() && !HasAsmWasmData();
448 } 447 }
449 448
450 } // namespace internal 449 } // namespace internal
451 } // namespace v8 450 } // namespace v8
452 451
453 #include "src/objects/object-macros-undef.h" 452 #include "src/objects/object-macros-undef.h"
454 453
455 #endif // V8_OBJECTS_SHARED_FUNCTION_INFO_INL_H_ 454 #endif // V8_OBJECTS_SHARED_FUNCTION_INFO_INL_H_
OLDNEW
« no previous file with comments | « src/objects/shared-function-info.h ('k') | test/cctest/test-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698