Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: src/deoptimizer.cc

Issue 2909893002: [debug] Untangle DebugInfo from break point support (Closed)
Patch Set: Address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/liveedit.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/deoptimizer.h" 5 #include "src/deoptimizer.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "src/accessors.h" 9 #include "src/accessors.h"
10 #include "src/assembler-inl.h" 10 #include "src/assembler-inl.h"
(...skipping 1245 matching lines...) Expand 10 before | Expand all | Expand 10 after
1256 1256
1257 // The new.target slot is only used during function activiation which is 1257 // The new.target slot is only used during function activiation which is
1258 // before the first deopt point, so should never be needed. Just set it to 1258 // before the first deopt point, so should never be needed. Just set it to
1259 // undefined. 1259 // undefined.
1260 output_offset -= kPointerSize; 1260 output_offset -= kPointerSize;
1261 Object* new_target = isolate_->heap()->undefined_value(); 1261 Object* new_target = isolate_->heap()->undefined_value();
1262 WriteValueToOutput(new_target, 0, frame_index, output_offset, "new_target "); 1262 WriteValueToOutput(new_target, 0, frame_index, output_offset, "new_target ");
1263 1263
1264 // Set the bytecode array pointer. 1264 // Set the bytecode array pointer.
1265 output_offset -= kPointerSize; 1265 output_offset -= kPointerSize;
1266 Object* bytecode_array = shared->HasDebugInfo() 1266 Object* bytecode_array = shared->HasBreakInfo()
1267 ? shared->GetDebugInfo()->DebugBytecodeArray() 1267 ? shared->GetDebugInfo()->DebugBytecodeArray()
1268 : shared->bytecode_array(); 1268 : shared->bytecode_array();
1269 WriteValueToOutput(bytecode_array, 0, frame_index, output_offset, 1269 WriteValueToOutput(bytecode_array, 0, frame_index, output_offset,
1270 "bytecode array "); 1270 "bytecode array ");
1271 1271
1272 // The bytecode offset was mentioned explicitly in the BEGIN_FRAME. 1272 // The bytecode offset was mentioned explicitly in the BEGIN_FRAME.
1273 output_offset -= kPointerSize; 1273 output_offset -= kPointerSize;
1274 int raw_bytecode_offset = 1274 int raw_bytecode_offset =
1275 BytecodeArray::kHeaderSize - kHeapObjectTag + bytecode_offset; 1275 BytecodeArray::kHeaderSize - kHeapObjectTag + bytecode_offset;
1276 Smi* smi_bytecode_offset = Smi::FromInt(raw_bytecode_offset); 1276 Smi* smi_bytecode_offset = Smi::FromInt(raw_bytecode_offset);
(...skipping 3179 matching lines...) Expand 10 before | Expand all | Expand 10 after
4456 CHECK(value_info->IsMaterializedObject()); 4456 CHECK(value_info->IsMaterializedObject());
4457 4457
4458 value_info->value_ = 4458 value_info->value_ =
4459 Handle<Object>(previously_materialized_objects->get(i), isolate_); 4459 Handle<Object>(previously_materialized_objects->get(i), isolate_);
4460 } 4460 }
4461 } 4461 }
4462 } 4462 }
4463 4463
4464 } // namespace internal 4464 } // namespace internal
4465 } // namespace v8 4465 } // namespace v8
OLDNEW
« no previous file with comments | « src/debug/liveedit.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698