Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: src/crankshaft/hydrogen.cc

Issue 2909893002: [debug] Untangle DebugInfo from break point support (Closed)
Patch Set: Address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-inlining.cc ('k') | src/debug/debug.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/hydrogen.h" 5 #include "src/crankshaft/hydrogen.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <sstream> 8 #include <sstream>
9 9
10 #include "src/allocation-site-scopes.h" 10 #include "src/allocation-site-scopes.h"
(...skipping 7858 matching lines...) Expand 10 before | Expand all | Expand 10 after
7869 7869
7870 CompilationInfo target_info(parse_info.zone(), &parse_info, 7870 CompilationInfo target_info(parse_info.zone(), &parse_info,
7871 target->GetIsolate(), target); 7871 target->GetIsolate(), target);
7872 7872
7873 if (inlining_kind != CONSTRUCT_CALL_RETURN && 7873 if (inlining_kind != CONSTRUCT_CALL_RETURN &&
7874 IsClassConstructor(target_shared->kind())) { 7874 IsClassConstructor(target_shared->kind())) {
7875 TraceInline(target, caller, "target is classConstructor"); 7875 TraceInline(target, caller, "target is classConstructor");
7876 return false; 7876 return false;
7877 } 7877 }
7878 7878
7879 if (target_shared->HasDebugInfo()) { 7879 if (target_shared->HasBreakInfo()) {
7880 TraceInline(target, caller, "target is being debugged"); 7880 TraceInline(target, caller, "target is being debugged");
7881 return false; 7881 return false;
7882 } 7882 }
7883 if (!Compiler::ParseAndAnalyze(&target_info)) { 7883 if (!Compiler::ParseAndAnalyze(&target_info)) {
7884 if (target_info.isolate()->has_pending_exception()) { 7884 if (target_info.isolate()->has_pending_exception()) {
7885 // Parse or scope error, never optimize this function. 7885 // Parse or scope error, never optimize this function.
7886 SetStackOverflow(); 7886 SetStackOverflow();
7887 target_shared->DisableOptimization(kParseScopeError); 7887 target_shared->DisableOptimization(kParseScopeError);
7888 } 7888 }
7889 TraceInline(target, caller, "parse failure"); 7889 TraceInline(target, caller, "parse failure");
(...skipping 4638 matching lines...) Expand 10 before | Expand all | Expand 10 after
12528 isolate()->GetHTracer()->TraceHydrogen(name(), graph_); 12528 isolate()->GetHTracer()->TraceHydrogen(name(), graph_);
12529 } 12529 }
12530 12530
12531 #ifdef DEBUG 12531 #ifdef DEBUG
12532 graph_->Verify(false); // No full verify. 12532 graph_->Verify(false); // No full verify.
12533 #endif 12533 #endif
12534 } 12534 }
12535 12535
12536 } // namespace internal 12536 } // namespace internal
12537 } // namespace v8 12537 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-inlining.cc ('k') | src/debug/debug.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698