Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: src/compiler/js-inlining.cc

Issue 2909893002: [debug] Untangle DebugInfo from break point support (Closed)
Patch Set: Address comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler.cc ('k') | src/crankshaft/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-inlining.h" 5 #include "src/compiler/js-inlining.h"
6 6
7 #include "src/ast/ast.h" 7 #include "src/ast/ast.h"
8 #include "src/compilation-info.h" 8 #include "src/compilation-info.h"
9 #include "src/compiler.h" 9 #include "src/compiler.h"
10 #include "src/compiler/all-nodes.h" 10 #include "src/compiler/all-nodes.h"
(...skipping 480 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 // See ES6 section 9.2.1 [[Call]] ( thisArgument, argumentsList ). 491 // See ES6 section 9.2.1 [[Call]] ( thisArgument, argumentsList ).
492 if (node->opcode() == IrOpcode::kJSCall && 492 if (node->opcode() == IrOpcode::kJSCall &&
493 IsClassConstructor(shared_info->kind())) { 493 IsClassConstructor(shared_info->kind())) {
494 TRACE("Not inlining %s into %s because callee is a class constructor.\n", 494 TRACE("Not inlining %s into %s because callee is a class constructor.\n",
495 shared_info->DebugName()->ToCString().get(), 495 shared_info->DebugName()->ToCString().get(),
496 info_->shared_info()->DebugName()->ToCString().get()); 496 info_->shared_info()->DebugName()->ToCString().get());
497 return NoChange(); 497 return NoChange();
498 } 498 }
499 499
500 // Function contains break points. 500 // Function contains break points.
501 if (shared_info->HasDebugInfo()) { 501 if (shared_info->HasBreakInfo()) {
502 TRACE("Not inlining %s into %s because callee may contain break points\n", 502 TRACE("Not inlining %s into %s because callee may contain break points\n",
503 shared_info->DebugName()->ToCString().get(), 503 shared_info->DebugName()->ToCString().get(),
504 info_->shared_info()->DebugName()->ToCString().get()); 504 info_->shared_info()->DebugName()->ToCString().get());
505 return NoChange(); 505 return NoChange();
506 } 506 }
507 507
508 // TODO(turbofan): TranslatedState::GetAdaptedArguments() currently relies on 508 // TODO(turbofan): TranslatedState::GetAdaptedArguments() currently relies on
509 // not inlining recursive functions. We might want to relax that at some 509 // not inlining recursive functions. We might want to relax that at some
510 // point. 510 // point.
511 for (Node* frame_state = call.frame_state(); 511 for (Node* frame_state = call.frame_state();
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
790 790
791 CommonOperatorBuilder* JSInliner::common() const { return jsgraph()->common(); } 791 CommonOperatorBuilder* JSInliner::common() const { return jsgraph()->common(); }
792 792
793 SimplifiedOperatorBuilder* JSInliner::simplified() const { 793 SimplifiedOperatorBuilder* JSInliner::simplified() const {
794 return jsgraph()->simplified(); 794 return jsgraph()->simplified();
795 } 795 }
796 796
797 } // namespace compiler 797 } // namespace compiler
798 } // namespace internal 798 } // namespace internal
799 } // namespace v8 799 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler.cc ('k') | src/crankshaft/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698