Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 2909793002: Fix r475187 which is a bad revert. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 7 months ago
Reviewers:
varkha, oshima, sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix r475187 which is a bad revert. It collided with r475096. TBR=sky@chromium.org,oshima@chromium.org,varkha@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/wm/maximize_mode/maximize_mode_window_state.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
oshima
lgtm sorry about that. I did compile locally but another CL might have landed in ...
3 years, 7 months ago (2017-05-27 00:31:51 UTC) #3
varkha
On 2017/05/27 00:31:51, oshima wrote: > lgtm > > sorry about that. I did compile ...
3 years, 7 months ago (2017-05-27 00:33:30 UTC) #4
Lei Zhang
On 2017/05/27 00:33:30, varkha wrote: > On 2017/05/27 00:31:51, oshima wrote: > > lgtm > ...
3 years, 7 months ago (2017-05-27 00:36:11 UTC) #5
varkha
3 years, 7 months ago (2017-05-27 00:38:07 UTC) #7
Message was sent while issue was closed.
On 2017/05/27 00:36:11, Lei Zhang wrote:
> On 2017/05/27 00:33:30, varkha wrote:
> > On 2017/05/27 00:31:51, oshima wrote:
> > > lgtm
> > > 
> > > sorry about that. I did compile locally but another CL might have landed
in
> > > between.
> > 
> > I have a CL in CQ for this - https://codereview.chromium.org/2913433002/
> 
> Great. I'll defer to your CL and close this one.

Thanks! It is pretty much same, except I have also restored the removal of a
header
that is no longer needed.

Powered by Google App Engine
This is Rietveld 408576698