Issue 2909723002: Revert "Refactor test option parsing code."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2909723002: Revert "Refactor test option parsing code." (Closed)

Created:
3 years, 6 months ago by Bob Nystrom

Modified:
3 years, 6 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Refactor test option parsing code." This reverts commit 9c2dff8ebc9f2c53d23ae46f71cf6e3b95a0e823. R=nweiz@google.com Committed: https://github.com/dart-lang/sdk/commit/d03835783ca866be10802a7411a85804ae263a1d

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1048 lines, -932 lines)			Patch
M	runtime/tests/vm/vm.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	samples/samples.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/testing/dart/co19_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/testing/dart/compiler_configuration.dart	View	12 chunks	+15 lines, -14 lines	0 comments	Download
M	tools/testing/dart/main.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
D	tools/testing/dart/options.dart	View	1 chunk	+0 lines, -908 lines	0 comments	Download
M	tools/testing/dart/package_testing_support.dart	View	1 chunk	+6 lines, -4 lines	0 comments	Download
A	tools/testing/dart/test_options.dart	View	1 chunk	+1012 lines, -0 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Bob Nystrom

3 years, 6 months ago (2017-05-26 20:51:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d03835783ca866be10802a7411a85804ae263a1d (presubmit successful).