Chromium Code Reviews| Index: tools/perf/page_sets/webrtc_cases.py |
| diff --git a/tools/perf/page_sets/webrtc_cases.py b/tools/perf/page_sets/webrtc_cases.py |
| index a6cacbaf071839d3661cf2a0ddea61aefe556f08..1a722dee37236f899815889dd46db97a7b751e9c 100644 |
| --- a/tools/perf/page_sets/webrtc_cases.py |
| +++ b/tools/perf/page_sets/webrtc_cases.py |
| @@ -6,6 +6,9 @@ from telemetry import story |
| from telemetry.page import page as page_module |
| +CODECS = ('OPUS', 'G772', 'PCMU', 'ISAC/1600') |
| + |
| + |
| class WebrtcPage(page_module.Page): |
| def __init__(self, url, page_set, name, tags): |
| @@ -110,13 +113,13 @@ class MultiplePeerConnections(WebrtcPage): |
| def RunPageInteractions(self, action_runner): |
| with action_runner.CreateInteraction('Action_Create_PeerConnection', |
| repeatable=False): |
| - # Set the number of peer connections to create to 15. |
| + # Set the number of peer connections to create to 10. |
| action_runner.ExecuteJavaScript( |
| - 'document.getElementById("num-peerconnections").value=15') |
| + 'document.getElementById("num-peerconnections").value=10') |
| action_runner.ExecuteJavaScript( |
| 'document.getElementById("cpuoveruse-detection").checked=false') |
| action_runner.ClickElement('button[id="start-test"]') |
| - action_runner.Wait(45) |
| + action_runner.Wait(20) |
| class WebrtcPageSet(story.StorySet): |
| @@ -124,25 +127,24 @@ class WebrtcPageSet(story.StorySet): |
| super(WebrtcPageSet, self).__init__( |
| cloud_storage_bucket=story.PUBLIC_BUCKET) |
| - self.AddStory(GetUserMedia(self, tags=['getusermedia'])) |
| self.AddStory(MultiplePeerConnections(self, tags=['stress'])) |
| - self.AddStory(VideoCall(self, tags=['peerconnection', 'smoothness'])) |
| self.AddStory(DataChannel(self, tags=['datachannel'])) |
| + self.AddStory(GetUserMedia(self, tags=['getusermedia'])) |
| + self.AddStory(VideoCall(self, tags=['peerconnection', 'smoothness'])) |
| self.AddStory(CanvasCapturePeerConnection(self, tags=['smoothness'])) |
| - # TODO(qyearsley, mcasas): Add webrtc.audio when http://crbug.com/468732 |
| - # is fixed, or revert https://codereview.chromium.org/1544573002/ when |
| - # http://crbug.com/568333 is fixed. |
| - # self.AddStory(AudioCall(self, 'OPUS')) |
| - # self.AddStory(AudioCall(self, 'G772')) |
| - # self.AddStory(AudioCall(self, 'PCMU')) |
| - # self.AddStory(AudioCall(self, 'ISAC/1600')) |
| + for codec in CODECS: |
|
nednguyen
2017/05/26 20:17:07
I also don't think code saving here is a good idea
|
| + self.AddStory(AudioCall(self, codec, tags=['audio'])) |
| class WebrtcExpectations(story.expectations.StoryExpectations): |
| def SetExpectations(self): |
| - self.DisableStory('multiple_peerconnections', |
| - [story.expectations.ALL], |
| - 'crbug.com/725502') |
| + # TODO(qyearsley, mcasas): Add webrtc.audio when http://crbug.com/468732 |
| + # is fixed, or revert https://codereview.chromium.org/1544573002/ when |
| + # http://crbug.com/568333 is fixed. |
| + for codec in CODECS: |
|
nednguyen
2017/05/26 20:16:09
No, please don't do this as it makes sheriffs supe
|
| + self.DisableStory('audio_call_%s_10s' % codec.lower(), |
| + [story.expectations.ALL], |
| + 'crbug.com/468732') |
| self.DisableStory('30s_datachannel_transfer', |
| [story.expectations.ALL_DESKTOP], |
| 'crbug.com/726811') |