Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: tools/perf/benchmarks/webrtc.py

Issue 2909653003: Re-enable the multiple_peerconnections story and disable webrtc traces and metrics. (Closed)
Patch Set: Address comment. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/webrtc_cases.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 6
7 import page_sets 7 import page_sets
8 from telemetry import benchmark 8 from telemetry import benchmark
9 from telemetry.timeline import chrome_trace_category_filter 9 from telemetry.timeline import chrome_trace_category_filter
10 from telemetry.web_perf import timeline_based_measurement 10 from telemetry.web_perf import timeline_based_measurement
11 11
12 12
13 @benchmark.Owner(emails=['qiangchen@chromium.org', # For smoothness metrics 13 @benchmark.Owner(emails=['qiangchen@chromium.org', # For smoothness metrics
14 'ehmaldonado@chromium.org', 14 'ehmaldonado@chromium.org',
15 'phoglund@chromium.org']) 15 'phoglund@chromium.org'])
16 class WebrtcPerfBenchmark(perf_benchmark.PerfBenchmark): 16 class WebrtcPerfBenchmark(perf_benchmark.PerfBenchmark):
17 """Base class for WebRTC metrics for real-time communications tests.""" 17 """Base class for WebRTC metrics for real-time communications tests."""
18 page_set = page_sets.WebrtcPageSet 18 page_set = page_sets.WebrtcPageSet
19 19
20 @classmethod 20 @classmethod
21 def Name(cls): 21 def Name(cls):
22 return 'webrtc' 22 return 'webrtc'
23 23
24 def CreateTimelineBasedMeasurementOptions(self): 24 def CreateTimelineBasedMeasurementOptions(self):
25 categories = [ 25 categories = [
26 # Disable all categories by default. 26 # Disable all categories by default.
27 '-*', 27 '-*',
28 'toplevel', 28 'toplevel',
29 # WebRTC 29 # WebRTC
30 'webrtc', 30 # TODO(ehmaldonado): Re-enable once http://crbug.com/725502 is fixed.
31 # 'webrtc',
31 ] 32 ]
32 33
33 category_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter( 34 category_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter(
34 filter_string=','.join(categories)) 35 filter_string=','.join(categories))
35 options = timeline_based_measurement.Options(category_filter) 36 options = timeline_based_measurement.Options(category_filter)
36 options.SetTimelineBasedMetrics([ 37 options.SetTimelineBasedMetrics([
37 'cpuTimeMetric', 38 'cpuTimeMetric',
38 'webrtcRenderingMetric', 39 # TODO(ehmaldonado): Re-enable once http://crbug.com/725502 is fixed.
40 # 'webrtcRenderingMetric',
39 ]) 41 ])
40 return options 42 return options
41 43
42 def SetExtraBrowserOptions(self, options): 44 def SetExtraBrowserOptions(self, options):
43 options.AppendExtraBrowserArgs('--use-fake-device-for-media-stream') 45 options.AppendExtraBrowserArgs('--use-fake-device-for-media-stream')
44 options.AppendExtraBrowserArgs('--use-fake-ui-for-media-stream') 46 options.AppendExtraBrowserArgs('--use-fake-ui-for-media-stream')
45 47
46 def GetExpectations(self): 48 def GetExpectations(self):
47 return page_sets.WebrtcExpectations() 49 return page_sets.WebrtcExpectations()
OLDNEW
« no previous file with comments | « no previous file | tools/perf/page_sets/webrtc_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698