Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: tools/perf/page_sets/webrtc_cases.py

Issue 2909653003: Re-enable the multiple_peerconnections story and disable webrtc traces and metrics. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/webrtc.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from telemetry import story 5 from telemetry import story
6 from telemetry.page import page as page_module 6 from telemetry.page import page as page_module
7 7
8 8
9 class WebrtcPage(page_module.Page): 9 class WebrtcPage(page_module.Page):
10 10
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 cloud_storage_bucket=story.PUBLIC_BUCKET) 125 cloud_storage_bucket=story.PUBLIC_BUCKET)
126 126
127 self.AddStory(GetUserMedia(self, tags=['getusermedia'])) 127 self.AddStory(GetUserMedia(self, tags=['getusermedia']))
128 self.AddStory(MultiplePeerConnections(self, tags=['stress'])) 128 self.AddStory(MultiplePeerConnections(self, tags=['stress']))
129 self.AddStory(VideoCall(self, tags=['peerconnection', 'smoothness'])) 129 self.AddStory(VideoCall(self, tags=['peerconnection', 'smoothness']))
130 self.AddStory(DataChannel(self, tags=['datachannel'])) 130 self.AddStory(DataChannel(self, tags=['datachannel']))
131 self.AddStory(CanvasCapturePeerConnection(self, tags=['smoothness'])) 131 self.AddStory(CanvasCapturePeerConnection(self, tags=['smoothness']))
132 # TODO(qyearsley, mcasas): Add webrtc.audio when http://crbug.com/468732 132 # TODO(qyearsley, mcasas): Add webrtc.audio when http://crbug.com/468732
133 # is fixed, or revert https://codereview.chromium.org/1544573002/ when 133 # is fixed, or revert https://codereview.chromium.org/1544573002/ when
134 # http://crbug.com/568333 is fixed. 134 # http://crbug.com/568333 is fixed.
135 # self.AddStory(AudioCall(self, 'OPUS')) 135 # self.AddStory(AudioCall(self, 'OPUS'))
nednguyen 2017/05/26 18:40:21 These disabling seem should be converted to the Se
136 # self.AddStory(AudioCall(self, 'G772')) 136 # self.AddStory(AudioCall(self, 'G772'))
137 # self.AddStory(AudioCall(self, 'PCMU')) 137 # self.AddStory(AudioCall(self, 'PCMU'))
138 # self.AddStory(AudioCall(self, 'ISAC/1600')) 138 # self.AddStory(AudioCall(self, 'ISAC/1600'))
139 139
140 140
141 class WebrtcExpectations(story.expectations.StoryExpectations): 141 class WebrtcExpectations(story.expectations.StoryExpectations):
142 def SetExpectations(self): 142 def SetExpectations(self):
143 self.DisableStory('multiple_peerconnections', [story.expectations.ALL], 143 pass
nednguyen 2017/05/26 18:30:52 this is wrong since it gonna return None. Randy: w
rnephew (Reviews Here) 2017/05/26 18:51:51 Its fine. This is the default for this method: htt
144 'crbug.com/725502')
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/webrtc.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698