Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: components/crash/content/app/crashpad.cc

Issue 2909623002: Change DumpProcessWithoutCrash to use load-time dynamic linking (Closed)
Patch Set: change to direct call Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/crash/content/app/crashpad.cc
diff --git a/components/crash/content/app/crashpad.cc b/components/crash/content/app/crashpad.cc
index ba04da14fe4f193efbd08c883cb7623e6335a63d..00d791fdc94f12e2d4eb092428b493e0695023f2 100644
--- a/components/crash/content/app/crashpad.cc
+++ b/components/crash/content/app/crashpad.cc
@@ -90,10 +90,6 @@ bool LogMessageHandler(int severity,
return false;
}
-void DumpWithoutCrashing() {
- CRASHPAD_SIMULATE_CRASH();
-}
-
void InitializeCrashpadImpl(bool initial_client,
const std::string& process_type,
const std::string& user_data_dir,
@@ -194,6 +190,10 @@ void InitializeCrashpadImpl(bool initial_client,
} // namespace
+void DumpWithoutCrashing() {
+ CRASHPAD_SIMULATE_CRASH();
robertshield 2017/06/22 18:15:41 nit: could you move this down to line 308 to keep
Will Harris 2017/06/26 12:26:20 Done.
+}
+
void InitializeCrashpad(bool initial_client, const std::string& process_type) {
InitializeCrashpadImpl(initial_client, process_type, std::string(), false);
}

Powered by Google App Engine
This is Rietveld 408576698