 Chromium Code Reviews
 Chromium Code Reviews Issue 2909623002:
  Change DumpProcessWithoutCrash to use load-time dynamic linking  (Closed)
    
  
    Issue 2909623002:
  Change DumpProcessWithoutCrash to use load-time dynamic linking  (Closed) 
  | Index: components/crash/content/app/crashpad.cc | 
| diff --git a/components/crash/content/app/crashpad.cc b/components/crash/content/app/crashpad.cc | 
| index ba04da14fe4f193efbd08c883cb7623e6335a63d..00d791fdc94f12e2d4eb092428b493e0695023f2 100644 | 
| --- a/components/crash/content/app/crashpad.cc | 
| +++ b/components/crash/content/app/crashpad.cc | 
| @@ -90,10 +90,6 @@ bool LogMessageHandler(int severity, | 
| return false; | 
| } | 
| -void DumpWithoutCrashing() { | 
| - CRASHPAD_SIMULATE_CRASH(); | 
| -} | 
| - | 
| void InitializeCrashpadImpl(bool initial_client, | 
| const std::string& process_type, | 
| const std::string& user_data_dir, | 
| @@ -194,6 +190,10 @@ void InitializeCrashpadImpl(bool initial_client, | 
| } // namespace | 
| +void DumpWithoutCrashing() { | 
| + CRASHPAD_SIMULATE_CRASH(); | 
| 
robertshield
2017/06/22 18:15:41
nit: could you move this down to line 308 to keep
 
Will Harris
2017/06/26 12:26:20
Done.
 | 
| +} | 
| + | 
| void InitializeCrashpad(bool initial_client, const std::string& process_type) { | 
| InitializeCrashpadImpl(initial_client, process_type, std::string(), false); | 
| } |