Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2878)

Unified Diff: base/debug/dump_without_crashing.cc

Issue 2909623002: Change DumpProcessWithoutCrash to use load-time dynamic linking (Closed)
Patch Set: change to direct call Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app/chrome_main.cc » ('j') | chrome_elf/chrome_elf.def » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/dump_without_crashing.cc
diff --git a/base/debug/dump_without_crashing.cc b/base/debug/dump_without_crashing.cc
index 4b338ca2930b69d110fd545176029aec75f9cd4a..c9ab4558056eda0e8a95d595e2f15cb2e4d5c355 100644
--- a/base/debug/dump_without_crashing.cc
+++ b/base/debug/dump_without_crashing.cc
@@ -27,6 +27,7 @@ bool DumpWithoutCrashing() {
}
void SetDumpWithoutCrashingFunction(void (CDECL *function)()) {
+ DCHECK(!dump_without_crashing_function_);
Will Harris 2017/06/26 12:26:20 this actually broke in component builds because th
dump_without_crashing_function_ = function;
}
« no previous file with comments | « no previous file | chrome/app/chrome_main.cc » ('j') | chrome_elf/chrome_elf.def » ('J')

Powered by Google App Engine
This is Rietveld 408576698