Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6941)

Unified Diff: chrome_elf/crash/crash_helper.h

Issue 2909623002: Change DumpProcessWithoutCrash to use load-time dynamic linking (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome_elf/crash/crash_helper.h
diff --git a/chrome_elf/crash/crash_helper.h b/chrome_elf/crash/crash_helper.h
index 4275abe212c7935bfaf85efce50c8a96bfe858c4..e4abb03c91b8587a9c8889a88f217f188b559244 100644
--- a/chrome_elf/crash/crash_helper.h
+++ b/chrome_elf/crash/crash_helper.h
@@ -27,6 +27,10 @@ void DisableSetUnhandledExceptionFilter();
// blacklist interception code, etc.
// Note: the handler takes a minidump.
int GenerateCrashDump(EXCEPTION_POINTERS* exception_pointers);
-}
+
+// Gets the DumpWithoutCrashing Function from crashpad, if available.
+void (*GetDumpWithoutCrashingFunction())();
scottmg 2017/06/15 23:08:47 So what's this one for? Sorry, I'm totally confuse
Will Harris 2017/06/15 23:37:24 this is the exposed interface from chrome_elf's cr
scottmg 2017/06/16 00:26:24 OK, I don't see the point of this, so you should g
+
+} // namespace elf_crash
#endif // CHROME_ELF_CRASH_CRASH_HELPER_H_

Powered by Google App Engine
This is Rietveld 408576698