base/debug/dump_without_crashing.cc - Issue 2909623002: Change DumpProcessWithoutCrash to use load-time dynamic linking

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/dump_without_crashing.cc

Issue 2909623002: Change DumpProcessWithoutCrash to use load-time dynamic linking (Closed)

Patch Set: code review comments Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/debug/dump_without_crashing.cc

diff --git a/base/debug/dump_without_crashing.cc b/base/debug/dump_without_crashing.cc

index 4b338ca2930b69d110fd545176029aec75f9cd4a..d6d810457e6b820a4dd019a0770aeb4cbd976d2c 100644

--- a/base/debug/dump_without_crashing.cc

+++ b/base/debug/dump_without_crashing.cc

@@ -27,6 +27,9 @@ bool DumpWithoutCrashing() {

}

void SetDumpWithoutCrashingFunction(void (CDECL *function)()) {

+#if !defined(COMPONENT_BUILD)

Nico 2017/06/26 14:36:14 add comment why this only holds in static builds

Will Harris 2017/06/26 16:27:04 Done.

+ DCHECK(!dump_without_crashing_function_);

+#endif

dump_without_crashing_function_ = function;

}

« no previous file with comments | « no previous file | chrome/app/chrome_main.cc » ('j') | no next file with comments »