Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: components/crash/content/app/crashpad.cc

Issue 2909623002: Change DumpProcessWithoutCrash to use load-time dynamic linking (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/crash/content/app/crashpad.h" 5 #include "components/crash/content/app/crashpad.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <string.h> 8 #include <string.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 if (should_initialize_database_and_set_upload_policy) { 187 if (should_initialize_database_and_set_upload_policy) {
188 g_database = 188 g_database =
189 crashpad::CrashReportDatabase::Initialize(database_path).release(); 189 crashpad::CrashReportDatabase::Initialize(database_path).release();
190 190
191 SetUploadConsent(crash_reporter_client->GetCollectStatsConsent()); 191 SetUploadConsent(crash_reporter_client->GetCollectStatsConsent());
192 } 192 }
193 } 193 }
194 194
195 } // namespace 195 } // namespace
196 196
197 void (*GetDumpWithoutCrashingFunction())() {
198 return DumpWithoutCrashing;
scottmg 2017/06/16 00:26:24 And, then instead of having this return a function
199 }
200
197 void InitializeCrashpad(bool initial_client, const std::string& process_type) { 201 void InitializeCrashpad(bool initial_client, const std::string& process_type) {
198 InitializeCrashpadImpl(initial_client, process_type, std::string(), false); 202 InitializeCrashpadImpl(initial_client, process_type, std::string(), false);
199 } 203 }
200 204
201 #if defined(OS_WIN) 205 #if defined(OS_WIN)
202 void InitializeCrashpadWithEmbeddedHandler(bool initial_client, 206 void InitializeCrashpadWithEmbeddedHandler(bool initial_client,
203 const std::string& process_type, 207 const std::string& process_type,
204 const std::string& user_data_dir) { 208 const std::string& user_data_dir) {
205 InitializeCrashpadImpl(initial_client, process_type, user_data_dir, true); 209 InitializeCrashpadImpl(initial_client, process_type, user_data_dir, true);
206 } 210 }
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 343
340 // This helper is invoked by code in chrome.dll to request a single crash report 344 // This helper is invoked by code in chrome.dll to request a single crash report
341 // upload. See CrashUploadListCrashpad. 345 // upload. See CrashUploadListCrashpad.
342 void __declspec(dllexport) 346 void __declspec(dllexport)
343 RequestSingleCrashUploadImpl(const std::string& local_id) { 347 RequestSingleCrashUploadImpl(const std::string& local_id) {
344 crash_reporter::RequestSingleCrashUpload(local_id); 348 crash_reporter::RequestSingleCrashUpload(local_id);
345 } 349 }
346 } // extern "C" 350 } // extern "C"
347 351
348 #endif // OS_WIN 352 #endif // OS_WIN
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698