Change DumpProcessWithoutCrash to use load-time dynamic linking

components/crash/content/app/crashpad_win.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/crash/content/app/crashpad.h"
 
 #include <memory>
 
 #include "base/debug/crash_logging.h"
 #include "base/environment.h"
@@ skipping 139 matching lines @@
   } else {
     std::string pipe_name_utf8;
     if (env->GetVar(kPipeNameVar, &pipe_name_utf8)) {
       GetCrashpadClient().SetHandlerIPCPipe(base::UTF8ToUTF16(pipe_name_utf8));
     }
   }
 
   return database_path;
 }
 
-// TODO(scottmg): http://crbug.com/546288 These exported functions are for
-// compatibility with how Breakpad worked, but it seems like there's no need to
-// do the CreateRemoteThread() dance with a minor extension of the Crashpad API
-// (to just pass the pid we want a dump for). We should add that and then modify
-// hang_crash_dump_win.cc to work in a more direct manner.
-
-// Used for dumping a process state when there is no crash.
-extern "C" void __declspec(dllexport) __cdecl DumpProcessWithoutCrash() {
-  CRASHPAD_SIMULATE_CRASH();
-}
-
 namespace {
 
+void DumpProcessWithoutCrash() {

[Will Harris, 2017/05/26 05:54:38]

not sure why we have two copies of this function... but they do the same thing
so ¯\_(ツ)_/¯

[scottmg, 2017/06/13 17:47:55]

It looks like
https://cs.chromium.org/chromium/src/chrome/browser/hang_monitor/hang_crash_d...
will need to be changed too.

[Will Harris, 2017/06/13 19:03:59]

sigh - does hang monitor have any tests...? :S

[Will Harris, 2017/06/15 22:54:38]

Done, the call was removed in another CL.

+  CRASHPAD_SIMULATE_CRASH();
+}
+
 // We need to prevent ICF from folding DumpForHangDebuggingThread(),
 // DumpProcessForHungInputThread(), DumpProcessForHungInputNoCrashKeysThread()
 // and DumpProcessWithoutCrashThread() together, since that makes them
 // indistinguishable in crash dumps. We do this by making the function
 // bodies unique, and prevent optimization from shuffling things around.
 MSVC_DISABLE_OPTIMIZE()
 MSVC_PUSH_DISABLE_WARNING(4748)
 
 // Note that this function must be in a namespace for the [Renderer hang]
 // annotations to work on the crash server.
@@ skipping 179 matching lines @@
 void __declspec(dllexport) __cdecl UnregisterNonABICompliantCodeRange(
     void* start) {
   ExceptionHandlerRecord* record =
       reinterpret_cast<ExceptionHandlerRecord*>(start);
 
   CHECK(RtlDeleteFunctionTable(&record->runtime_function));
 }
 #endif  // ARCH_CPU_X86_64
 
 }  // extern "C"