Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2909603002: Revert of Remove InputMethodEventHandler. (Closed)

Created:
3 years, 7 months ago by yawano
Modified:
3 years, 6 months ago
CC:
chromium-reviews, kalyank
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove InputMethodEventHandler. (patchset #16 id:300001 of https://codereview.chromium.org/2872343003/ ) Reason for revert: This CL makes TalkBack in Android window unusable. The issue is that after this CL, key event becomes to go through event rewriter in Chrome. TalkBack doesn't expect that events are rewritten by Chrome. Original issue's description: > Remove InputMethodEventHandler. > > This change removes InputMethodEventHandler and instead sends the events > to IME in WindowEventDispatcher::PreDispatchEvent(). > > > This is a step towards unifying key event processing path in classic ash and > mus+ash. > > BUG=719269 > > Review-Url: https://codereview.chromium.org/2872343003 > Cr-Commit-Position: refs/heads/master@{#472941} > Committed: https://chromium.googlesource.com/chromium/src/+/9f9dddf904a9eae86f20d0fa3f68c1881a360d80 TBR=sadrul@chromium.org,sky@chromium.org,reillyg@chromium.org,moshayedi@google.com,moshayedi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=719269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+275 lines, -42 lines) Patch
M ash/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/display/window_tree_host_manager.h View 3 chunks +6 lines, -0 lines 0 comments Download
M ash/display/window_tree_host_manager.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host.h View 3 chunks +12 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/host/ash_window_tree_host_platform.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_platform.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_unified.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 2 chunks +10 lines, -0 lines 0 comments Download
A ash/ime/input_method_event_handler.h View 1 chunk +42 lines, -0 lines 0 comments Download
A ash/ime/input_method_event_handler.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M ash/mus/ash_window_tree_host_mus.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/mus/ash_window_tree_host_mus.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M ash/shell.cc View 3 chunks +12 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M extensions/shell/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A extensions/shell/browser/input_method_event_handler.h View 1 chunk +42 lines, -0 lines 0 comments Download
A extensions/shell/browser/input_method_event_handler.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.h View 2 chunks +3 lines, -0 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller_aura.cc View 4 chunks +19 lines, -1 line 0 comments Download
M ui/aura/test/aura_test_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/test/aura_test_utils.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/aura/window_event_dispatcher.h View 3 chunks +0 lines, -7 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 4 chunks +0 lines, -14 lines 0 comments Download
M ui/aura/window_tree_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/aura/window_tree_host.cc View 1 chunk +1 line, -7 lines 0 comments Download
M ui/events/test/event_generator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
yawano
Created Revert of Remove InputMethodEventHandler.
3 years, 7 months ago (2017-05-26 03:26:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2909603002/1
3 years, 7 months ago (2017-05-26 05:38:41 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/219706) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 7 months ago (2017-05-26 05:42:16 UTC) #5
sadrul
On 2017/05/26 03:26:17, yawano wrote: > Created Revert of Remove InputMethodEventHandler. Did you file a ...
3 years, 7 months ago (2017-05-26 12:15:44 UTC) #6
yawano
On 2017/05/26 12:15:44, sadrul wrote: > On 2017/05/26 03:26:17, yawano wrote: > > Created Revert ...
3 years, 6 months ago (2017-05-29 01:51:28 UTC) #7
Hadi
3 years, 6 months ago (2017-05-29 14:24:51 UTC) #8
On 2017/05/29 01:51:28, yawano wrote:
> On 2017/05/26 12:15:44, sadrul wrote:
> > On 2017/05/26 03:26:17, yawano wrote:
> > > Created Revert of Remove InputMethodEventHandler.
> > 
> > Did you file a bug about TalkBack not working?
> 
> No, not yet in http://crbug.com. Filed at https://crbug.com/727179.

Created a rebased version of this at https://codereview.chromium.org/2909063002/

Powered by Google App Engine
This is Rietveld 408576698