Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/public/cpp/bindings/tests/pickle_unittest.cc

Issue 2909593002: Disable tests on VS 2017 Preview, code-gen bug (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/bindings/tests/pickle_unittest.cc
diff --git a/mojo/public/cpp/bindings/tests/pickle_unittest.cc b/mojo/public/cpp/bindings/tests/pickle_unittest.cc
index e5cc26709a793dd3fbe2981e21bec6ee9434094a..39f0572d8da28106bd368a3889b5e8b1a999cb6b 100644
--- a/mojo/public/cpp/bindings/tests/pickle_unittest.cc
+++ b/mojo/public/cpp/bindings/tests/pickle_unittest.cc
@@ -182,8 +182,9 @@ class PickleTest : public testing::Test {
} // namespace
-#if _MSC_FULL_VER == 191025017
-// Disabled due to this VS 2017 RTM code-gen bug:
+#if _MSC_FULL_VER == 191025017 || _MSC_FULL_VER == 191125303
+// Disabled due to this VS 2017 RTM code-gen bug, still present in Update 3
+// Preview 1:
// https://developercommunity.visualstudio.com/content/problem/40904/bad-code-gen-in-chromes-mojo-public-bindings-unitt.html
#define MAYBE_ChromiumProxyToChromiumService \
DISABLED_ChromiumProxyToChromiumService
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698