third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp - Issue 2909553002: [DMC #20] Remove DocumentMarker::IsActiveMatch() and SetIsActiveMatch() methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

Issue 2909553002: [DMC #20] Remove DocumentMarker::IsActiveMatch() and SetIsActiveMatch() methods (Closed)

Patch Set: Update comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/markers/DocumentMarker.cpp ('k') | third_party/WebKit/Source/core/editing/markers/TextMatchMarker.h » ('j') | third_party/WebKit/Source/core/layout/svg/line/SVGInlineTextBox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

index 18d25c08b5aa3d098e27b13be317dccbe1340309..d9cd745a7d4587011d0f7e76a7154062e5644c25 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

@@ -662,7 +662,9 @@ void DocumentMarkerController::ShowMarkers() const {

builder.Append(":");

builder.AppendNumber(marker->EndOffset());

builder.Append("](");

- builder.AppendNumber(marker->IsActiveMatch());

+ builder.AppendNumber(type == DocumentMarker::kTextMatch

+ ? ToTextMatchMarker(marker)->IsActiveMatch()

+ : 0);

builder.Append(")");

}