Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 290953002: Use ki_* socket methods in socket_test to fix linux trusted mode. (Closed)

Created:
6 years, 7 months ago by bradn
Modified:
6 years, 7 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Visibility:
Public.

Description

Use ki_* socket methods in socket_test to fix linux trusted mode. We recently switch to using glibc hooks for interception on glibc. Where in the past calls like ki_accept and accept could be assumed to be the same, now they rely on wrapping. Changing inconsistent use of ki_ vs not in socket_test. BUG=None TEST=nacl_io_socket_test R=binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc View 10 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bradn
6 years, 7 months ago (2014-05-19 18:30:41 UTC) #1
binji
lgtm % trybots
6 years, 7 months ago (2014-05-19 18:45:43 UTC) #2
bradn
6 years, 7 months ago (2014-05-19 19:35:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r271453 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698