Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2909503004: Update strong mode expectations to reflect kernel type parameter conventions. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update strong mode expectations to reflect kernel type parameter conventions. When outputting the name of a type parameter, Kernel follows two special conventions: - It fully qualifies the name of the type parameter with respect to the scope of its declaration; so for example a type parameter `T` of a class `C` in a library `lib` might be annotated as `lib::C::T`. - Within a factory constructor, type parameters of the class are annotated as though they are type parameters of the factory constructor (this is because factory constructors are represented in kernel as static methods). This CL adjusts the strong mode type inference tests to reflect this behavior (and modifies analyzer's front_end_inference_test so that follows the kernel conventions). R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/1e45167514710ea01de8bcb26572ad2666f7cf5e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -50 lines) Patch
M pkg/analyzer/test/src/task/strong/front_end_inference_test.dart View 10 chunks +87 lines, -39 lines 0 comments Download
M pkg/front_end/test/fasta/strong.status View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/testcases/inference/constructors_infer_from_arguments_factory.dart.strong.expect View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_factory_calls_constructor.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_infer_from_arguments_named_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/testcases/inference/constructors_infer_from_arguments_named_factory.dart.strong.expect View 1 chunk +18 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_inference_f_bounded.dart View 1 chunk +1 line, -1 line 0 comments Download
A pkg/front_end/testcases/inference/constructors_inference_f_bounded.dart.strong.expect View 1 chunk +24 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/constructors_reverse_type_parameters.dart View 1 chunk +3 lines, -1 line 0 comments Download
A pkg/front_end/testcases/inference/constructors_reverse_type_parameters.dart.strong.expect View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-25 17:55:52 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-25 18:00:36 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-25 18:11:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1e45167514710ea01de8bcb26572ad2666f7cf5e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698