chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js - Issue 2909503003: WebUI: Enable ESLint rule for missing semicolons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js

Issue 2909503003: WebUI: Enable ESLint rule for missing semicolons. (Closed)

Patch Set: Undo local_ntp changes from this CL. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/braille/braille_table.js ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/injected/event_suspender.js » ('j') | chrome/browser/ui/webui/options/certificate_manager_browsertest.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js

diff --git a/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js b/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js

index 0a8bdfbd0ba3f1542db324679d0ccea6c5851172..563f8e1391667b344f2068852d02730d67392dd8 100644

--- a/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js

+++ b/chrome/browser/resources/chromeos/chromevox/braille/expanding_braille_translator.js

@@ -152,7 +152,7 @@ cvox.ExpandingBrailleTranslator.prototype.translate =

function finish() {

var totalCells = chunks.reduce(

- function(accum, chunk) { return accum + chunk.cells.byteLength}, 0);

+ function(accum, chunk) { return accum + chunk.cells.byteLength;}, 0);

dschuyler 2017/05/26 19:00:25 optional: I think a space should follow the ';' (t

dpapad 2017/05/26 19:08:39 clang-format will do this (but I am not running it

var cells = new Uint8Array(totalCells);

var cellPos = 0;

var textToBraille = [];