Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Unified Diff: chrome/browser/permissions/permission_util.cc

Issue 2909453002: Support persist toggle in PermissionRequestManager path on Android (Closed)
Patch Set: rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/permissions/permission_util.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_util.cc
diff --git a/chrome/browser/permissions/permission_util.cc b/chrome/browser/permissions/permission_util.cc
index 927b0a9c6cbf1b8f16be26574ed05959b787ea02..1dc6cc6c63743c9e1c41d7042a6a1af027733d19 100644
--- a/chrome/browser/permissions/permission_util.cc
+++ b/chrome/browser/permissions/permission_util.cc
@@ -161,9 +161,12 @@ bool PermissionUtil::IsPermission(ContentSettingsType type) {
}
}
-bool PermissionUtil::ShouldShowPersistenceToggle() {
- return base::FeatureList::IsEnabled(
- features::kDisplayPersistenceToggleInPermissionPrompts);
+bool PermissionUtil::ShouldShowPersistenceToggle(ContentSettingsType type) {
+ return (type == CONTENT_SETTINGS_TYPE_GEOLOCATION ||
+ type == CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC ||
+ type == CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA) &&
+ base::FeatureList::IsEnabled(
+ features::kDisplayPersistenceToggleInPermissionPrompts);
}
PermissionUtil::ScopedRevocationReporter::ScopedRevocationReporter(
« no previous file with comments | « chrome/browser/permissions/permission_util.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698