chrome/browser/permissions/permission_request_impl.cc - Issue 2909453002: Support persist toggle in PermissionRequestManager path on Android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/permissions/permission_request_impl.cc

Issue 2909453002: Support persist toggle in PermissionRequestManager path on Android (Closed)

Patch Set: rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/permissions/permission_request_impl.cc

diff --git a/chrome/browser/permissions/permission_request_impl.cc b/chrome/browser/permissions/permission_request_impl.cc

index cc87658778947c6961c3dd732e342f5e72425153..fbc860d3c9874fd0506ede69e922ce7426153e38 100644

--- a/chrome/browser/permissions/permission_request_impl.cc

+++ b/chrome/browser/permissions/permission_request_impl.cc

@@ -194,8 +194,7 @@ void PermissionRequestImpl::RequestFinished() {

}

bool PermissionRequestImpl::ShouldShowPersistenceToggle() const {

- return (content_settings_type_ == CONTENT_SETTINGS_TYPE_GEOLOCATION) &&

- PermissionUtil::ShouldShowPersistenceToggle();

+ return PermissionUtil::ShouldShowPersistenceToggle(content_settings_type_);

}

PermissionRequestType PermissionRequestImpl::GetPermissionRequestType()