Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: runtime/vm/dart.cc

Issue 2909403002: When deduplicating program metadata, try to use objects from the VM isolate. (Closed)
Patch Set: sync Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/dart.h ('k') | runtime/vm/heap.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/dart.h" 5 #include "vm/dart.h"
6 6
7 #include "vm/become.h" 7 #include "vm/become.h"
8 #include "vm/clustered_snapshot.h" 8 #include "vm/clustered_snapshot.h"
9 #include "vm/code_observers.h" 9 #include "vm/code_observers.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 DECLARE_FLAG(bool, trace_time_all); 43 DECLARE_FLAG(bool, trace_time_all);
44 DEFINE_FLAG(bool, keep_code, false, "Keep deoptimized code for profiling."); 44 DEFINE_FLAG(bool, keep_code, false, "Keep deoptimized code for profiling.");
45 DEFINE_FLAG(bool, trace_shutdown, false, "Trace VM shutdown on stderr"); 45 DEFINE_FLAG(bool, trace_shutdown, false, "Trace VM shutdown on stderr");
46 46
47 Isolate* Dart::vm_isolate_ = NULL; 47 Isolate* Dart::vm_isolate_ = NULL;
48 int64_t Dart::start_time_micros_ = 0; 48 int64_t Dart::start_time_micros_ = 0;
49 ThreadPool* Dart::thread_pool_ = NULL; 49 ThreadPool* Dart::thread_pool_ = NULL;
50 DebugInfo* Dart::pprof_symbol_generator_ = NULL; 50 DebugInfo* Dart::pprof_symbol_generator_ = NULL;
51 ReadOnlyHandles* Dart::predefined_handles_ = NULL; 51 ReadOnlyHandles* Dart::predefined_handles_ = NULL;
52 Snapshot::Kind Dart::vm_snapshot_kind_ = Snapshot::kInvalid; 52 Snapshot::Kind Dart::vm_snapshot_kind_ = Snapshot::kInvalid;
53 const uint8_t* Dart::vm_snapshot_instructions_ = NULL;
53 Dart_ThreadExitCallback Dart::thread_exit_callback_ = NULL; 54 Dart_ThreadExitCallback Dart::thread_exit_callback_ = NULL;
54 Dart_FileOpenCallback Dart::file_open_callback_ = NULL; 55 Dart_FileOpenCallback Dart::file_open_callback_ = NULL;
55 Dart_FileReadCallback Dart::file_read_callback_ = NULL; 56 Dart_FileReadCallback Dart::file_read_callback_ = NULL;
56 Dart_FileWriteCallback Dart::file_write_callback_ = NULL; 57 Dart_FileWriteCallback Dart::file_write_callback_ = NULL;
57 Dart_FileCloseCallback Dart::file_close_callback_ = NULL; 58 Dart_FileCloseCallback Dart::file_close_callback_ = NULL;
58 Dart_EntropySource Dart::entropy_source_callback_ = NULL; 59 Dart_EntropySource Dart::entropy_source_callback_ = NULL;
59 60
60 // Structure for managing read-only global handles allocation used for 61 // Structure for managing read-only global handles allocation used for
61 // creating global read-only handles that are pre created and initialized 62 // creating global read-only handles that are pre created and initialized
62 // for use across all isolates. Having these global pre created handles 63 // for use across all isolates. Having these global pre created handles
(...skipping 688 matching lines...) Expand 10 before | Expand all | Expand 10 after
751 ASSERT(predefined_handles_ != NULL); 752 ASSERT(predefined_handles_ != NULL);
752 return predefined_handles_->handles_.IsValidScopedHandle(address); 753 return predefined_handles_->handles_.IsValidScopedHandle(address);
753 } 754 }
754 755
755 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) { 756 bool Dart::IsReadOnlyApiHandle(Dart_Handle handle) {
756 ASSERT(predefined_handles_ != NULL); 757 ASSERT(predefined_handles_ != NULL);
757 return predefined_handles_->api_handles_.IsValidHandle(handle); 758 return predefined_handles_->api_handles_.IsValidHandle(handle);
758 } 759 }
759 760
760 } // namespace dart 761 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/dart.h ('k') | runtime/vm/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698