Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2909383002: GN: Build snapshot assembly files w/r/t current_toolchain. (Closed)

Created:
3 years, 6 months ago by rmacnak
Modified:
3 years, 6 months ago
Reviewers:
zra
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

GN: Build snapshot assembly files w/r/t current_toolchain. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/3f03d305b4974284a2a99349cb311946573070fb

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/bin/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 6 months ago (2017-05-30 20:35:46 UTC) #2
zra
lgtm
3 years, 6 months ago (2017-05-30 21:52:56 UTC) #3
rmacnak
3 years, 6 months ago (2017-05-30 22:19:22 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3f03d305b4974284a2a99349cb311946573070fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698