Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1595)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc

Issue 2909293002: Allow tasks scheduled for the instant virtual time budges expires to run (Closed)
Patch Set: Changes for altimin@ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
index 8bdac815503bdd49cb51284a9574a8098724c812..507872fb8bf00483f9b3b25c6b53962406363e1d 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
@@ -614,13 +614,13 @@ TEST_F(WebViewSchedulerImplTest, SuspendTimersWhileVirtualTimeIsPaused) {
std::unique_ptr<WebFrameSchedulerImpl> web_frame_scheduler =
web_view_scheduler_->CreateWebFrameSchedulerImpl(nullptr);
- web_frame_scheduler->TimerTaskRunner()->PostDelayedTask(
- BLINK_FROM_HERE, WTF::Bind(&RunOrderTask, 1, WTF::Unretained(&run_order)),
- TimeDelta());
-
web_view_scheduler_->SetVirtualTimePolicy(VirtualTimePolicy::PAUSE);
web_view_scheduler_->EnableVirtualTime();
+ web_frame_scheduler->TimerTaskRunner()->PostTask(
+ BLINK_FROM_HERE,
+ WTF::Bind(&RunOrderTask, 1, WTF::Unretained(&run_order)));
+
mock_task_runner_->RunUntilIdle();
EXPECT_TRUE(run_order.empty());
@@ -681,9 +681,11 @@ TEST_F(WebViewSchedulerImplTest, VirtualTimeBudgetExhaustedCallback) {
// The timer that is scheduled for the exact point in time when virtual time
// expires will not run.
- EXPECT_THAT(real_times, ElementsAre(initial_real_time, initial_real_time));
+ EXPECT_THAT(real_times, ElementsAre(initial_real_time, initial_real_time,
+ initial_real_time));
EXPECT_THAT(virtual_times_ms, ElementsAre(initial_virtual_time_ms + 1,
- initial_virtual_time_ms + 2));
+ initial_virtual_time_ms + 2,
+ initial_virtual_time_ms + 5));
}
namespace {

Powered by Google App Engine
This is Rietveld 408576698