Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2909293002: Allow tasks scheduled for the instant virtual time budges expires to run (Closed)
Patch Set: Changes for altimin@ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
index fa6a06c86d0821630db268290ca2b6f145301b08..1f335c7acafbdbbd9d9e99594f2e421964c7ce1d 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
@@ -219,6 +219,7 @@ RendererSchedulerImpl::MainThreadOnly::MainThreadOnly(
in_idle_period_for_testing(false),
use_virtual_time(false),
is_audio_playing(false),
+ virtual_time_paused(false),
rail_mode_observer(nullptr),
wake_up_budget_pool(nullptr),
task_duration_per_queue_type_histogram(base::Histogram::FactoryGet(
@@ -370,6 +371,8 @@ scoped_refptr<TaskQueue> RendererSchedulerImpl::NewTimerTaskQueue(
TimeDomainType::THROTTLED) {
task_queue_throttler_->IncreaseThrottleRefCount(timer_task_queue.get());
}
+ if (GetMainThreadOnly().virtual_time_paused)
+ timer_task_queue->InsertFence(TaskQueue::InsertFencePosition::NOW);
timer_task_queue->AddTaskObserver(
&GetMainThreadOnly().timer_task_cost_estimator);
AddQueueToWakeUpBudgetPool(timer_task_queue.get());
@@ -1413,6 +1416,25 @@ void RendererSchedulerImpl::ResumeTimerQueue() {
ForceUpdatePolicy();
}
+void RendererSchedulerImpl::VirtualTimePaused() {
+ DCHECK(!GetMainThreadOnly().virtual_time_paused);
+ GetMainThreadOnly().virtual_time_paused = true;
+ for (const auto& pair : timer_task_runners_) {
+ DCHECK(!task_queue_throttler_->IsThrottled(pair.first.get()));
+ DCHECK(!pair.first->HasFence());
+ pair.first->InsertFence(TaskQueue::InsertFencePosition::NOW);
+ }
+}
+
+void RendererSchedulerImpl::VirtualTimeResumed() {
+ DCHECK(GetMainThreadOnly().virtual_time_paused);
+ GetMainThreadOnly().virtual_time_paused = false;
+ for (const auto& pair : timer_task_runners_) {
+ DCHECK(!task_queue_throttler_->IsThrottled(pair.first.get()));
+ pair.first->RemoveFence();
+ }
+}
+
void RendererSchedulerImpl::SetTimerQueueSuspensionWhenBackgroundedEnabled(
bool enabled) {
// Note that this will only take effect for the next backgrounded signal.
@@ -1527,6 +1549,8 @@ RendererSchedulerImpl::AsValueLocked(base::TimeTicks optional_now) const {
.timer_task_cost_estimator.expected_task_duration()
.InMillisecondsF());
state->SetBoolean("is_audio_playing", GetMainThreadOnly().is_audio_playing);
+ state->SetBoolean("virtual_time_paused",
+ GetMainThreadOnly().virtual_time_paused);
state->BeginDictionary("web_view_schedulers");
for (WebViewSchedulerImpl* web_view_scheduler :

Powered by Google App Engine
This is Rietveld 408576698