Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2909293002: Allow tasks scheduled for the instant virtual time budges expires to run (Closed)
Patch Set: Changes for altimin@ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index 72a3068a235f10de51cfbc452b68ff4a87c2d887..5c026524aec3368fe3805317d47204e972ef64cb 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -1422,10 +1422,10 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, VirtualTimeTest) {
params->SetString("expression", "console.log('done')");
SendCommand("Runtime.evaluate", std::move(params), true);
- // The second timer shold not fire.
- EXPECT_THAT(console_messages_, ElementsAre("before", "done"));
+ // The third timer should not fire.
+ EXPECT_THAT(console_messages_, ElementsAre("before", "at", "done"));
- // Let virtual time advance for another second, which should make the second
+ // Let virtual time advance for another second, which should make the third
// timer fire.
params.reset(new base::DictionaryValue());
params->SetString("policy", "advance");
@@ -1434,7 +1434,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, VirtualTimeTest) {
WaitForNotification("Emulation.virtualTimeBudgetExpired");
- EXPECT_THAT(console_messages_, ElementsAre("before", "done", "at", "after"));
+ EXPECT_THAT(console_messages_, ElementsAre("before", "at", "done", "after"));
}
// Tests that the Security.showCertificateViewer command shows the
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698