Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_browsertest.cc

Issue 2909293002: Allow tasks scheduled for the instant virtual time budges expires to run (Closed)
Patch Set: Fix Fix DevTools test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/devtools_protocol_browsertest.cc
diff --git a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
index 72a3068a235f10de51cfbc452b68ff4a87c2d887..108cef4364e6355298cdfd5f41e0bbb668afcc7f 100644
--- a/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
+++ b/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
@@ -1423,7 +1423,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, VirtualTimeTest) {
SendCommand("Runtime.evaluate", std::move(params), true);
// The second timer shold not fire.
Sami 2017/05/31 10:47:43 Please update this comment.
alex clarke (OOO till 29th) 2017/05/31 11:01:48 Done.
- EXPECT_THAT(console_messages_, ElementsAre("before", "done"));
+ EXPECT_THAT(console_messages_, ElementsAre("before", "at", "done"));
// Let virtual time advance for another second, which should make the second
Sami 2017/05/31 10:47:43 This one looks out of date too.
alex clarke (OOO till 29th) 2017/05/31 11:01:47 Done.
// timer fire.
@@ -1434,7 +1434,7 @@ IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, VirtualTimeTest) {
WaitForNotification("Emulation.virtualTimeBudgetExpired");
- EXPECT_THAT(console_messages_, ElementsAre("before", "done", "at", "after"));
+ EXPECT_THAT(console_messages_, ElementsAre("before", "at", "done", "after"));
}
// Tests that the Security.showCertificateViewer command shows the

Powered by Google App Engine
This is Rietveld 408576698