chrome/browser/ui/webui/sync_internals_message_handler.cc - Issue 2909283003: [Sync] Split UserEventService into interface and impl, add fake impl, add unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_internals_message_handler.cc

Issue 2909283003: [Sync] Split UserEventService into interface and impl, add fake impl, add unit tests. (Closed)

Patch Set: Added a NoOp service to handle OffTheRecord. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/sync_internals_message_handler.cc

diff --git a/chrome/browser/ui/webui/sync_internals_message_handler.cc b/chrome/browser/ui/webui/sync_internals_message_handler.cc

index e67fbc1a7a7458646184fdf31e877bd1bc5fd339..c629de94a1996688dd5eb9990d90832668aa9b41 100644

--- a/chrome/browser/ui/webui/sync_internals_message_handler.cc

+++ b/chrome/browser/ui/webui/sync_internals_message_handler.cc

@@ -215,8 +215,7 @@ void SyncInternalsMessageHandler::HandleWriteUserEvent(

Profile* profile = Profile::FromWebUI(web_ui());

syncer::UserEventService* user_event_service =

- browser_sync::UserEventServiceFactory::GetForProfile(

- profile->GetOriginalProfile());

+ browser_sync::UserEventServiceFactory::GetForProfile(profile);

sync_pb::UserEventSpecifics event_specifics;

event_specifics.set_event_time_usec(StringAtIndexToInt64(args, 0));